Repository navigation
Conversation
mmichel11
force-pushed
the
matt/native_recording_errc_tests
branch
from
August 12, 2026 15:31
a334dac to
a5fd762
Compare
mmichel11
force-pushed
the
matt/native_recording_errc_tests
branch
from
September 9, 2026 16:13
a5fd762 to
200e647
Compare
mmichel11
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new external-event test has a broken lit directive and a queue::single_task call that does not match any available overload, which will prevent the tests from being gated/compiled correctly.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds new SYCL Graph native-recording end-to-end negative tests to validate newly introduced UR/Level Zero error scenarios, and removes now-obsolete TODO commentary in existing “Inputs” exception tests.
Changes:
- Add native-recording e2e tests for: unjoined forks at
end_recording, illegal cross-graph merge attempts, and “external/internal event” boundary violations. - Remove outdated TODO comments in existing queue-wait and event-wait recording exception tests.
File summaries
| File | Description |
|---|---|
| sycl/test-e2e/Graph/RecordReplay/NativeRecording/exception_unjoined_fork.cpp | New e2e test expecting errc::runtime when ending a recording with an unjoined fork. |
| sycl/test-e2e/Graph/RecordReplay/NativeRecording/exception_merge.cpp | New e2e test expecting errc::runtime when a cross-graph dependency would merge recordings. |
| sycl/test-e2e/Graph/RecordReplay/NativeRecording/exception_external_event.cpp | New e2e test covering “external event pulled into graph” and “internal event escaping graph” error paths. |
| sycl/test-e2e/Graph/Inputs/exception_recording_queue_wait.cpp | Removes outdated TODO comment; behavior remains the same. |
| sycl/test-e2e/Graph/Inputs/exception_recording_event_wait.cpp | Removes outdated TODO comment; behavior remains the same. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mmichel11
force-pushed
the
matt/native_recording_errc_tests
branch
from
October 5, 2026 19:08
d310198 to
385c4c6
Compare
mmichel11
changed the title
mmichel11
commented
Oct 5, 2026
| @@ -0,0 +1,64 @@ | |||
| // REQUIRES: level_zero_v2_adapter && arch-intel_gpu_bmg_g21 | |||
| // REQUIRES: linux | |||
| // REQUIRES-INTEL-DRIVER: lin: 39428 | |||
Contributor
Author
There was a problem hiding this comment.
Will add these to my list for when we turn on Windows testing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds e2e tests assessing new error scenarios in the native graph backend. These cases were previously forbidden by native graphs but did not always return errors from L0.