-
Notifications
You must be signed in to change notification settings - Fork 791
[SYCL] Adds support for atomic fence capabilities device queries #8586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steffenlarsen
merged 43 commits into
intel:sycl
from
maarquitos14:maronas/atomic_fence_capabilities
Mar 28, 2023
Merged
Changes from 36 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
435d760
Adds preliminar support for atomic_fence_order_capabilities.
maarquitos14 d126996
Adds support for atomic fence capabilities device queries.
maarquitos14 fbb2998
Adds tests for atomic fence capabilities device queries.
maarquitos14 8e07de6
Updateds atomic fence capabilities unittest.
maarquitos14 8327cb0
Updates ABI test.
maarquitos14 46e315a
Reverts involuntary change.
maarquitos14 4bad01d
Updates atomic fence capabilities unittest.
maarquitos14 3a24574
Updates PI version.
maarquitos14 eeb02e9
Fixes compilation error in CUDA.
maarquitos14 8829169
Update atomic fence capabilities unittest header.
maarquitos14 fc36ecc
Merge remote-tracking branch 'intel/origin/sycl' into maronas/atomic_…
maarquitos14 0ce9beb
Fixes clang-format issue.
maarquitos14 60132b7
Fixes clang-format issues.
maarquitos14 36192ee
SYCL should always return memory_scope::work_item.
maarquitos14 c1cf809
Addressing code review concerncs.
maarquitos14 bf12a92
Reverts unrelated changes.
maarquitos14 9548073
Addresses code review comments.
maarquitos14 4c59edb
Reverts unrelated clang-format changes.
maarquitos14 3ab7991
Reverts unrelated clang-format changes.
maarquitos14 f19eb4c
Reverts unrelated clang-format changes.
maarquitos14 9e7947c
Sets return values correctly in piDeviceGetInfo for atomic fence capa…
maarquitos14 806e054
Addresses code review comments.
maarquitos14 c55f52a
Addresses code review comments.
maarquitos14 b01fef5
Merge remote-tracking branch 'intel/origin/sycl' into maronas/atomic_…
maarquitos14 30bc569
Merge remote-tracking branch 'intel/origin/sycl' into maronas/atomic_…
maarquitos14 1571410
Addresses code review comments.
maarquitos14 cda1cd3
Merge remote-tracking branch 'intel/origin/sycl' into maronas/atomic_…
maarquitos14 45dd762
Addresses code review comments.
maarquitos14 d4a5d37
Fixes compilation error in AtomicMemoryOrderCapabilities unittest.
maarquitos14 918b923
Fixes compilation error in AtomicFenceCapabilities unittest.
maarquitos14 6490a36
Updates Windows ABI.
maarquitos14 924b9b7
Removes file pushed accidentally.
maarquitos14 879c096
Adds ur2pi value conversion.
maarquitos14 aea9486
Merges branches with common code.
maarquitos14 2522df7
Merge remote-tracking branch 'intel/origin/sycl' into maronas/atomic_…
maarquitos14 8d37dfb
Fixes merge issue.
maarquitos14 2e1d848
Addresses code review comments.
maarquitos14 38b415f
Adds context query for atomic_fence_capabilities.
maarquitos14 20f5e18
Updates Windows ABI.
maarquitos14 bef2e36
Returns minimum mandated capabilities for atomic capabilities in HIP.
maarquitos14 626b231
Merge remote-tracking branch 'intel/origin/sycl' into maronas/atomic_…
maarquitos14 cc6166e
Raise errors when querying context for atomic capabilities.
maarquitos14 ffc9b92
Fixes compilation error in HIP.
maarquitos14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,6 +43,10 @@ const int UR_EXT_DEVICE_INFO_FREE_MEMORY = UR_EXT_DEVICE_INFO_END - 13; | |
// const int ZER_EXT_DEVICE_INFO_DEVICE_ID = UR_EXT_DEVICE_INFO_END - 14; | ||
// const int ZER_EXT_DEVICE_INFO_IMAGE_MAX_ARRAY_SIZE = | ||
// UR_DEVICE_INFO_IMAGE_MAX_ARRAY_SIZE; | ||
const int UR_DEVICE_INFO_ATOMIC_FENCE_ORDER_CAPABILITIES = | ||
UR_EXT_DEVICE_INFO_END - 16; | ||
const int UR_DEVICE_INFO_ATOMIC_FENCE_SCOPE_CAPABILITIES = | ||
UR_EXT_DEVICE_INFO_END - 17; | ||
Comment on lines
+46
to
+49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kbenzie: please take this change into UR |
||
|
||
const ur_device_info_t UR_EXT_DEVICE_INFO_OPENCL_C_VERSION = | ||
(ur_device_info_t)0x103D; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.