Skip to content

[SYCL] Reenable fp64 aspect runtime check #8682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2023
Merged

[SYCL] Reenable fp64 aspect runtime check #8682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92f7701
[SYCL] Reenable fp64 aspect runtime check
steffenlarsen Mar 16, 2023
8733950
Switch to no-sycl-early-optimizations to avoid unrecognized -O0
steffenlarsen Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sycl/source/detail/program_manager/program_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ RT::PiProgram ProgramManager::getBuiltPIProgram(
while (AIt != AEnd) {
auto Aspect = static_cast<aspect>(*AIt);
// Strict check for fp64 is disabled temporarily to avoid confusion.
if (Aspect != aspect::fp64 && !Dev->has(Aspect))
if (!Dev->has(Aspect))
throw sycl::exception(errc::kernel_not_supported,
"Required aspect " + getAspectNameStr(Aspect) +
" is not supported on the device");
Expand Down Expand Up @@ -2309,7 +2309,7 @@ bool doesDevSupportDeviceRequirements(const device &Dev,
while (!Aspects.empty()) {
aspect Aspect = Aspects.consume<aspect>();
// Strict check for fp64 is disabled temporarily to avoid confusion.
if (Aspect != aspect::fp64 && !Dev.has(Aspect))
if (!Dev.has(Aspect))
return false;
}
}
Expand Down
24 changes: 24 additions & 0 deletions sycl/test/optional_kernel_features/relaxed_fp64_propagation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
// RUN: %clangxx %s -S -o %t_opt.ll -fsycl-device-only -Xclang -verify -Xclang -verify-ignore-unexpected=note
// RUN: FileCheck %s --input-file %t_opt.ll --check-prefix=CHECK-OPT
// RUN: %clangxx %s -S -fno-sycl-early-optimizations -o %t_noopt.ll -fsycl-device-only -Xclang -verify -Xclang -verify-ignore-unexpected=note
// RUN: FileCheck %s --input-file %t_noopt.ll --check-prefix=CHECK-NOOPT

// Tests that an optimization that removes the use of double still produces a
// warning.

// CHECK-OPT-NOT: double
// CHECK-NOOPT: double

#include <sycl/sycl.hpp>

int main() {
sycl::queue Q;
// expected-warning-re@+1 {{function '{{.*}}' uses aspect 'fp64' not listed in its 'sycl::device_has' attribute}}
Q.single_task([=]() [[sycl::device_has()]] {
// Double will be optimized out as LoweredFloat can be set directly to a
// lowered value.
double Double = 3.14;
volatile float LoweredFloat = Double;
});
return 0;
}