better solution for checking g_idx support #2251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin He <[email protected]>
yiliu30
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR improves the detection of g_idx (group_index) support in Habana PyTorch Extension (HPEX) by replacing version-based checking with runtime schema inspection. The change fixes a bug where version 1.21.2 was incorrectly assumed to support g_idx based solely on version comparison.
- Replaces version-based g_idx support detection with runtime schema inspection
- Adds LRU caching to optimize repeated support checks
- Updates import statements to reflect the new function name
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| neural_compressor/torch/utils/environ.py | Replaces get_hpex_version() with is_hpex_support_g_idx() that checks schema instead of version |
| neural_compressor/torch/algorithms/weight_only/modules.py | Updates import and usage to call the new g_idx support detection function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug fix: 1.21.2 doesn't support g_idx
1.22.0:
1.21.2: