Skip to content

Conversation

@XuehaoSun
Copy link
Contributor

@XuehaoSun XuehaoSun commented Oct 22, 2025

User description

Type of Change

feature or bug fix or documentation or validation or others
API changed or not

Description

detail description

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed


PR Type

Enhancement


Description

  • Updated --extra-index-url to --index-url in READMEs

  • Modified installation commands for PyTorch and Intel extensions

  • Removed unnecessary submodule cloning and setup steps


Diagram Walkthrough

flowchart LR
  A["Update README.md"] -- "Change --extra-index-url to --index-url" --> B["Modify installation commands"]
  B -- "Remove submodule cloning" --> C["Simplify setup steps"]
Loading

File Walkthrough

Relevant files
Enhancement
README.md
Update PyTorch installation command                                           

examples/deprecated/pytorch/nlp/huggingface_models/text-to-image/inference/README.md

  • Changed --extra-index-url to --index-url for PyTorch installation
+1/-1     
README.md
Update and simplify installation commands                               

examples/pytorch/nlp/huggingface_models/language-modeling/quantization/transformers/weight_only/text-generation/README.md

  • Changed --extra-index-url to --index-url for oneccl_bind_pt
    installation
  • Added torch and intel-extension-for-pytorch installations with
    --extra-index-url
  • Removed submodule cloning and setup steps for ipex-gpu
+3/-8     
requirements_GPU.txt
Clean up GPU requirements                                                               

examples/pytorch/nlp/huggingface_models/language-modeling/quantization/transformers/weight_only/text-generation/requirements_GPU.txt

  • Removed --extra-index-url and torch version specification
+0/-2     
requirements_cpu_woq.txt
Update CPU requirements                                                                   

examples/pytorch/nlp/huggingface_models/language-modeling/quantization/transformers/weight_only/text-generation/requirements_cpu_woq.txt

  • Changed --extra-index-url to --index-url for PyTorch installation
  • Removed torch version specification
+1/-3     

Signed-off-by: Sun, Xuehao <[email protected]>
@PRAgent4INC
Copy link
Collaborator

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Inconsistent Index URL

The README.md file uses --index-url for one package and --extra-index-url for another. This inconsistency should be addressed to ensure uniformity and correctness.

pip install oneccl_bind_pt==2.4.0 --index-url https://pytorch-extension.intel.com/release-whl/stable/cpu/us/
pip install -r requirements_cpu_woq.txt --extra-index-url https://download.pytorch.org/whl/cpu
Missing Index URL

The requirements_GPU.txt file is missing the --extra-index-url for the torch package, which might cause installation issues.

peft
protobuf
sentencepiece != 0.1.92
Version Mismatch

The requirements_cpu_woq.txt file specifies torch==2.4.0, but the README.md file specifies torch==2.4.0+cpu. This version mismatch should be resolved.

torch==2.4.0

@PRAgent4INC
Copy link
Collaborator

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Use consistent pip flags

Ensure consistency by using either --index-url or --extra-index-url consistently
across all package installations.

examples/pytorch/nlp/huggingface_models/language-modeling/quantization/transformers/weight_only/text-generation/README.md [122-123]

-pip install oneccl_bind_pt==2.3.100+xpu --index-url https://pytorch-extension.intel.com/release-whl/stable/xpu/us/
+pip install oneccl_bind_pt==2.3.100+xpu --extra-index-url https://pytorch-extension.intel.com/release-whl/stable/xpu/us/
 pip install torch==2.3.1+cxx11.abi intel-extension-for-pytorch==2.3.110+xpu --extra-index-url https://pytorch-extension.intel.com/release-whl/stable/xpu/us/
Suggestion importance[1-10]: 6

__

Why: Ensuring consistency in pip flags improves readability and reduces potential confusion, but it does not address a critical issue.

Low

@XuehaoSun XuehaoSun requested a review from thuang6 October 22, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants