fix(point-of-sale): added bruno script + added missing env variables to local docker compose file #3629

oana-lolea · 2025-09-04T09:34:42Z

Added bruno script to initiate a payment.
Fixes #3542
Linear #1120

Also fixed the flow in the payment route.
Linear #1151

Also added environment variables for POS and Cards services in local playground.
Fixes #3619
Linear #1150

…ainers

github-actions · 2025-09-04T09:39:29Z

🚀 Performance Test Results

Test Configuration:

VUs: 4
Duration: 1m0s

Test Metrics:

Requests/s: 45.10
Iterations/s: 15.04
Failed Requests: 0.00% (0 of 2714)

📜 Logs


> [email protected] run-tests:testenv /home/runner/work/rafiki/rafiki/test/performance
> ./scripts/run-tests.sh -e test "-k" "-q" "--vus" "4" "--duration" "1m"

Cloud Nine GraphQL API is up: http://localhost:3101/graphql
Cloud Nine Wallet Address is up: http://localhost:3100/
Happy Life Bank Address is up: http://localhost:4100/
cloud-nine-wallet-test-backend already set
cloud-nine-wallet-test-auth already set
happy-life-bank-test-backend already set
happy-life-bank-test-auth already set
     data_received..................: 980 kB 16 kB/s
     data_sent......................: 2.1 MB 35 kB/s
     http_req_blocked...............: avg=6.04µs   min=2.33µs   med=5.05µs   max=348.51µs p(90)=6.22µs   p(95)=6.73µs  
     http_req_connecting............: avg=223ns    min=0s       med=0s       max=148µs    p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=88.06ms  min=7.64ms   med=72.24ms  max=486.15ms p(90)=151.37ms p(95)=176.03ms
       { expected_response:true }...: avg=88.06ms  min=7.64ms   med=72.24ms  max=486.15ms p(90)=151.37ms p(95)=176.03ms
     http_req_failed................: 0.00%  ✓ 0         ✗ 2714
     http_req_receiving.............: avg=85.8µs   min=26.98µs  med=72.18µs  max=2.57ms   p(90)=109.63µs p(95)=138.67µs
     http_req_sending...............: avg=35.44µs  min=10.02µs  med=26.19µs  max=2.76ms   p(90)=39.22µs  p(95)=54.51µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=87.94ms  min=7.46ms   med=72.14ms  max=486.09ms p(90)=151.3ms  p(95)=175.92ms
     http_reqs......................: 2714   45.101235/s
     iteration_duration.............: avg=265.69ms min=174.91ms med=251.17ms max=1.02s    p(90)=328.18ms p(95)=366.06ms
     iterations.....................: 905    15.039284/s
     vus............................: 4      min=4       max=4 
     vus_max........................: 4      min=4       max=4

mkurapov · 2025-09-04T15:53:45Z

bruno/collections/Rafiki/POS Service APIs/Initiate Payment.bru

+body:json {
+  {
+    "card": {
+      "walletAddress": "http://localhost:3000/accounts/gfranklin",


I believe we should be passing in https://cloud-nine-wallet/... here, since the POS service will get it in the request and should find the wallet address using the shared rafiki network set up in the docker compose

…Payment mutation

oana-lolea · 2025-09-08T10:54:33Z

packages/backend/src/app.ts

    // we don't need to verify the signature nor prevent replay attacks
    koa.use(
-      this.config.env !== 'test'
+      this.config.env !== 'test' && this.config.env !== 'development'


Added this so that I can bypass the tenant signature check for now while testing

I think if the TENANT_SECRET matches the API_SECRET from above, then this validation should work without having to bypass it

oana-lolea · 2025-09-08T10:57:55Z

packages/point-of-sale/src/payments/routes.ts

      value: body.value
    }
    const incomingPayment = await deps.paymentService.createIncomingPayment(
      walletAddress.id,


This needs to be the UUID of the wallet address, not the actual address. Will add a request to fetch that.

mkurapov · 2025-09-09T11:27:34Z

bruno/collections/Rafiki/POS Service APIs/Initiate Payment.bru

+}
+
+post {
+  url: http://localhost:3008/payment


Suggested change

url: http://localhost:3008/payment

url: http://localhost:4008/payment

Let's do this, such that the incoming payment will be on the happy-life side of things, and cloud nine will pay into it.

mkurapov · 2025-09-09T11:28:59Z

packages/point-of-sale/src/payments/service.ts

+    ...(tenantId && {
+      context: {
+        headers: {
+          'tenant-id': tenantId
+        }
+      }
+    })


We are already passing in the tenantId when we are setting up the apolloClient (index.ts), so I think we can leave this out

mkurapov · 2025-09-09T11:29:37Z

localenv/cloud-nine-wallet/docker-compose.yml

+      GRAPHQL_URL: http://cloud-nine-wallet-backend:3001/graphql
+      TENANT_ID: 438fa74a-fa7d-4317-9ced-dde32ece1787
+      TENANT_SECRET: tenant_secret
+      TENANT_SIGNATURE_VERSION: tenant_signature_version


Suggested change

TENANT_SIGNATURE_VERSION: tenant_signature_version

TENANT_SIGNATURE_VERSION: 1

oana-lolea · 2025-09-10T11:37:35Z

packages/point-of-sale/src/card-service-client/client.ts

      requestId: uuid()
    }
-    const cardServiceUrl = options.card.walletAddress.cardService
    const response = await deps.axios.post<PaymentResponse>(


Will get BAD_REQUEST because we are missing some data that cardService is expecting.

oana-lolea · 2025-09-10T11:39:33Z

localenv/cloud-nine-wallet/docker-compose.yml

      - rafiki
    ports:
      - '3007:3007'
+      - '9234:9229'


Added for debugging

oana-lolea · 2025-09-10T11:39:39Z

localenv/happy-life-bank/docker-compose.yml

      - rafiki 
    ports: 
      - '4008:4008' 
+      - '9233:9229'


Added for debugging

mkurapov · 2025-09-12T10:39:32Z

localenv/cloud-nine-wallet/docker-compose.yml

      DATABASE_URL: postgresql://cloud_nine_wallet_card_service:cloud_nine_wallet_card_service@shared-database/cloud_nine_wallet_card_service
+      GRAPHQL_URL: http://cloud-nine-wallet-backend:3001/graphql
+      TENANT_ID: 438fa74a-fa7d-4317-9ced-dde32ece1787
+      TENANT_SECRET: tenant_secret


TENANT_SECRET should match the API_SECRET from backend container

mkurapov · 2025-09-12T10:42:07Z

packages/backend/src/app.ts

    // we don't need to verify the signature nor prevent replay attacks
    koa.use(
-      this.config.env !== 'test'
+      this.config.env !== 'test' && this.config.env !== 'development'


I think if the TENANT_SECRET matches the API_SECRET from above, then this validation should work without having to bypass it

mkurapov · 2025-09-12T10:43:17Z

packages/point-of-sale/src/payments/service.ts

  const { data } = await client.mutate<
-    Mutation['createIncomingPayment'],
-    CreateIncomingPaymentInput
+    Mutation,


Suggested change

Mutation,

CreateIncomingPayment,

Importing this from '../graphql/generated/graphql' should give you the correct type for the Mutation

Added bruno script + added missing env variables to local docker cont…

606d215

…ainers

oana-lolea requested a review from mkurapov September 4, 2025 09:46

oana-lolea marked this pull request as ready for review September 4, 2025 09:47

Added missing env variables for card-service

14728c4

mkurapov reviewed Sep 4, 2025

View reviewed changes

Sent tenant id to backend for now, updated bruno req, fixed createInc…

b824561

…Payment mutation

github-actions bot added pkg: backend Changes in the backend package. type: source Changes business logic labels Sep 8, 2025

oana-lolea commented Sep 8, 2025

View reviewed changes

oana-lolea added 3 commits September 8, 2025 13:58

Removed unnecessary header

77b3c62

Merge branch 'pos-card-services' into oana/raf-1120

69bf632

Fixed a test after mutation update

2c17a92

github-actions bot added the type: tests Testing related label Sep 8, 2025

Updated generated graphql files

e08e900

mkurapov reviewed Sep 9, 2025

View reviewed changes

oana-lolea added 3 commits September 9, 2025 14:57

Merge branch 'pos-card-services' into oana/raf-1120

d6743f1

Fixed connection between payment service calls

49e5ae3

Merge branch 'pos-card-services' into oana/raf-1120

73e0c3c

oana-lolea requested a review from mkurapov September 10, 2025 11:36

oana-lolea commented Sep 10, 2025

View reviewed changes

localenv/cloud-nine-wallet/docker-compose.yml

- rafiki

ports:

- '3007:3007'

- '9234:9229'

Copy link

Contributor Author

oana-lolea Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added for debugging

oana-lolea commented Sep 10, 2025

View reviewed changes

localenv/happy-life-bank/docker-compose.yml

- rafiki

ports:

- '4008:4008'

- '9233:9229'

Copy link

Contributor Author

oana-lolea Sep 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added for debugging

mkurapov reviewed Sep 15, 2025

View reviewed changes

Fixed env variables and mutation type for creating inc payment

91402d1

github-actions bot removed pkg: backend Changes in the backend package. type: source Changes business logic labels Sep 17, 2025

oana-lolea requested a review from mkurapov September 17, 2025 06:22

mkurapov approved these changes Sep 17, 2025

View reviewed changes

oana-lolea merged commit 50efa05 into pos-card-services Sep 17, 2025
28 of 40 checks passed

oana-lolea deleted the oana/raf-1120 branch September 17, 2025 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(point-of-sale): added bruno script + added missing env variables to local docker compose file #3629

fix(point-of-sale): added bruno script + added missing env variables to local docker compose file #3629

Uh oh!

oana-lolea commented Sep 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 4, 2025 •

edited

Loading

Uh oh!

mkurapov Sep 4, 2025

Uh oh!

oana-lolea Sep 8, 2025

Uh oh!

mkurapov Sep 12, 2025

Uh oh!

oana-lolea Sep 8, 2025

Uh oh!

mkurapov Sep 9, 2025

Uh oh!

mkurapov Sep 9, 2025

Uh oh!

mkurapov Sep 9, 2025

Uh oh!

oana-lolea Sep 10, 2025

Uh oh!

oana-lolea Sep 10, 2025

Uh oh!

oana-lolea Sep 10, 2025

Uh oh!

mkurapov Sep 12, 2025

Uh oh!

mkurapov Sep 12, 2025

Uh oh!

mkurapov Sep 12, 2025

Uh oh!

Uh oh!

Uh oh!

	url: http://localhost:3008/payment
	url: http://localhost:4008/payment

	TENANT_SIGNATURE_VERSION: tenant_signature_version
	TENANT_SIGNATURE_VERSION: 1

fix(point-of-sale): added bruno script + added missing env variables to local docker compose file #3629

fix(point-of-sale): added bruno script + added missing env variables to local docker compose file #3629

Uh oh!

Conversation

oana-lolea commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Performance Test Results

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

oana-lolea commented Sep 4, 2025 •

edited

Loading

github-actions bot commented Sep 4, 2025 •

edited

Loading