chore: switch requests_testadapter for requests_mock #8595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requests_testadapter is an archived repository Carries on from invoke-ai#4252 (comment)
06kellyjac
requested review from
lstein,
blessedcoolant,
psychedelicious and
hipsterusername
as code owners
github-actions
bot
added
Root
python-tests
|
Thanks! Unfortunately, If we want to migrate, https://github.com/getsentry/responses appears to be the de-facto choice and is actively maintained. Looks like there is a bit more to it than the other libraries but it's still pretty small. |
|
ah, darn. I'll rework this 🙂 Also I'm not sure why my imports are in the wrong order. I thought I ran ruff. Maybe it was affected when I rebased. |
|
Maybe the venv wasn't activated when running As for |
|
Ah ok. Yeah, it's just it downloads a tonne of stuff on to a drive I don't have much space on. 😅 I'll work something out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
requests_testadapter is an archived repository
Carries on from #4252 (comment)
Implementation using
requests_mockis broadly similar and I wouldn't say it's much more complex thanrequests_testadapterTODO still need to update uv lock, help updating this would be good. Also wanted to raise the PR to get feedback now.
Related Issues / Discussions
relates to #4252
QA Instructions
Rerunning the tests is sufficient.
I've not ran the longer/more extensive suite but the default tests all run.
Merge Plan
Non user facing code so shouldn't require a merge plan.
Checklist
What's Newcopy (if doing a release after this PR)