Fix storage meta folder cleanup when deleting adapter instances #3087
Conversation
Co-authored-by: Apollon77 <[email protected]>
Copilot
AI
changed the title
…back - Fixed JSDoc placement issue (was between JSDoc and method implementation) - Implemented _enumerateInstanceMeta method using _enumerateAdapterMeta pattern - Created shared _deleteFiles method for file deletion logic - Refactored _deleteAdapterFiles to use shared method - Added _deleteInstanceFiles that uses enumeration approach instead of collectExistingFilesToDelete - Moved file deletion call before object deletion in deleteInstance method - Fixed TypeScript syntax and formatting issues Co-authored-by: Apollon77 <[email protected]>
- Add optional instance parameter to _enumerateAdapterMeta method following the pattern of other enumerate methods - Remove duplicate _enumerateInstanceMeta method - Update _deleteInstanceFiles to use the generalized method - Update JSDoc to document the new parameter This follows the DRY principle and reduces code duplication as requested in review feedback. Co-authored-by: Apollon77 <[email protected]>
There was a problem hiding this comment.
@copilot Additionally please add a changelog entry to the CHANGELOG.md file because this is an functional change. Please focus on the "effect" of the change and not write it too technical.
Also please add to the copilot instructions that changelog entries should be added for functional changes or enhancements.
Co-authored-by: Apollon77 <[email protected]>
Added changelog entry focusing on the user-facing effect: "Fixed cleanup of storage meta folder files when deleting adapter instances". Also updated copilot instructions to include guidance about adding changelog entries for functional changes. e38d457 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Apollon77 <[email protected]>
No ... Wanted to check if we have such tests already and maybe task him to add tests for it :-) It is basically just trying around ... |
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
_enumerateInstanceMetapattern_deleteFilesmethod_deleteAdapterFilesto use shared deletion method_enumerateAdapterMetato accept optional instance parameter_enumerateInstanceMetamethod_deleteInstanceFilesto use generalized enumeration methodThe implementation now correctly cleans up storage meta folder files when deleting adapter instances by:
_enumerateAdapterMetamethod that can handle both adapter-wide and instance-specific enumeration_enumerateAdapterDevices, etc.) with optional instance parameter_enumerateInstanceMetamethod_deleteFilesmethod for consistent file deletion logicadapterPrefixvariableThis ensures that when instances like
ical.0orical.1are deleted, all associated meta files are properly cleaned up, preventing orphaned files from accumulating in the storage.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.