RMET-4099 :: added chooseFromGallery feature#1
RMET-4099 :: added chooseFromGallery feature#1OS-ruimoreiramendes wants to merge 60 commits intofeat/RMET-4099/camera-unificationfrom
Conversation
For better separation and testability
Removing unused files from example-app
Otherwise the camera pages would become extremely large
Otherwise pwa functionality is limited
For page to not grow as large
…/new-capacitor-example-app
Possible issue in saving to file and calling EditURIPhoto on Android with Capacitor plugin, still to be investigated.
To make sure there's no issue with edge-to-edge
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
Overall everything looks good! From what I've been testing these days with the example app the new methods seem to be working well!
Just leaving a comment regarding something that I noticed, but it's non-blocker and we can change later so I'll approve the PR.
There was a problem hiding this comment.
This isn't a big deal but: Correct me if I'm wrong but could be a data class instead with val fields in constructor instead of var. Or are fields changing at later dates, and if so why?
There was a problem hiding this comment.
From what I can see, the values are not changed later, they are loaded once and not modified afterwards. So I think it would be fine to apply the change you suggested.
That said, I followed this approach because it’s the same we already use in CameraSettings. Do you think it still makes sense to change it here as well?
There was a problem hiding this comment.
Yeah, that, and I think VideoSettings too. So if we change one, we should change the others. Whether this needs to be done in this PR or not, I'll leave that up to you 😄
There was a problem hiding this comment.
Ok, I will change it in this PR
3 participants
No description provided.