Skip to content

docs(components): include images in 3x size to improve clarity and update the v7 components page #4198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 17, 2025

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Jul 16, 2025

Some of the images were previously uploaded at 1x and others at 2x resolution. This PR updates all images to 3x size for improved clarity on high pixel density displays.

Before After

This also updates the v7 components page to match v8.

Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2025 8:58pm

@brandyscarney brandyscarney marked this pull request as ready for review July 16, 2025 19:19
@brandyscarney brandyscarney requested a review from a team as a code owner July 16, 2025 19:19
@brandyscarney brandyscarney requested review from gnbm and ShaneK July 16, 2025 19:19
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Some images were removed without replacement, I assume they're no longer referenced?

@brandyscarney
Copy link
Member Author

brandyscarney commented Jul 16, 2025

Yes we haven't had header or footer on that page in forever - definitely not v6 or v7. And slides was also removed. I did break v7 renaming the searchbar icon though so fixed: 39e5a9c

Copy link
Contributor

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney changed the title docs(components): include images in 3x size to improve clarity docs(components): include images in 3x size to improve clarity and update the v7 components page Jul 17, 2025
@brandyscarney brandyscarney merged commit e9d05f6 into main Jul 17, 2025
4 checks passed
@brandyscarney brandyscarney deleted the docs/component-images branch July 17, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants