Skip to content

fix(checkbox): improve states and colors #30559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 22, 2025
Merged

fix(checkbox): improve states and colors #30559

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e097720
- errorText and state only appears when checkbox is unchecked;
JoaoFerreira-FrontEnd Jul 18, 2025
d01cc5c
Merge branch 'next' into ROU-12073
JoaoFerreira-FrontEnd Jul 18, 2025
f939ab0
lint.fix;
JoaoFerreira-FrontEnd Jul 18, 2025
25a9464
- remove invalid rule;
JoaoFerreira-FrontEnd Jul 21, 2025
dda4489
- add states test;
JoaoFerreira-FrontEnd Jul 21, 2025
2be6fa4
chore(): add updated snapshots
Ionitron Jul 21, 2025
ab0b5ce
-lint.fix
JoaoFerreira-FrontEnd Jul 21, 2025
3498129
- guarrantee invalid state border just for unchecked state;
JoaoFerreira-FrontEnd Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 29 additions & 11 deletions core/src/components/checkbox/checkbox.ionic.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@

// Size
--size: #{globals.$ion-scale-600};
--checkbox-background-checked: #{globals.$ion-semantics-primary-base};
--checkbox-background: #{globals.$ion-bg-input-default};
--checkbox-background-checked: #{globals.$ion-bg-primary-base-default};
--border-color-checked: #{globals.$ion-semantics-primary-base};
--checkmark-color: #{globals.$ion-primitives-base-white};
--transition: none;
Expand Down Expand Up @@ -116,11 +117,11 @@ input {
}

.checkbox-bottom .error-text {
color: globals.$ion-semantics-danger-800;
color: globals.$ion-text-danger;
}

.checkbox-bottom .helper-text {
color: globals.$ion-primitives-neutral-800;
color: globals.$ion-text-subtlest;
}

// Label Placement - Start
Expand Down Expand Up @@ -187,7 +188,6 @@ input {

// Checked / Indeterminate Checkbox
// ---------------------------------------------

:host(.checkbox-checked) .native-wrapper,
:host(.checkbox-indeterminate) .native-wrapper {
border-color: var(--border-color-checked);
Expand All @@ -197,11 +197,17 @@ input {

// Ionic Design Checkbox Invalid
// --------------------------------------------------
:host(.ion-invalid) {
:host(.ion-invalid:not(.checkbox-checked)) {
--focus-ring-color: #{globals.$ion-border-focus-error};

.native-wrapper {
border-color: globals.$ion-semantics-danger-800;
border-color: globals.$ion-border-danger-default;
}
}

:host(.ion-invalid:not(.checkbox-checked).checkbox-disabled) {
.native-wrapper {
border-color: globals.$ion-border-danger-default;
}
}

Expand All @@ -222,7 +228,7 @@ input {
:host(.checkbox-disabled.checkbox-checked) .native-wrapper {
border-width: globals.$ion-border-size-0;

background-color: globals.$ion-semantics-primary-base;
background-color: globals.$ion-bg-primary-base-default;
}

// Checkbox Hover
Expand All @@ -233,7 +239,9 @@ input {
}

:host(:hover.checkbox-checked) .native-wrapper,
:host(:hover.checkbox-indeterminate) .native-wrapper {
:host(:hover.checkbox-checked) .checkbox-icon,
:host(:hover.checkbox-indeterminate) .native-wrapper,
:host(:hover.checkbox-indeterminate) .checkbox-icon {
background-color: globals.$ion-semantics-primary-800;
}
}
Expand All @@ -248,12 +256,22 @@ input {
// Checkbox: Active
// --------------------------------------------------------
:host(.ion-activated) .native-wrapper {
background-color: globals.$ion-primitives-neutral-200;
background-color: globals.$ion-bg-input-press;
}

:host(.ion-activated.checkbox-checked) .native-wrapper,
:host(.ion-activated.checkbox-indeterminate) .native-wrapper {
background-color: globals.$ion-semantics-primary-900;
:host(.ion-activated.checkbox-checked) .checkbox-icon,
:host(.ion-activated.checkbox-indeterminate) .native-wrapper,
:host(.ion-activated.checkbox-indeterminate) .checkbox-icon {
background-color: globals.$ion-bg-primary-base-press;
}

:host(.ion-activated.ion-invalid:not(.checkbox-checked)) {
background-color: globals.$ion-bg-input-press;

.native-wrapper {
border-color: globals.$ion-border-danger-press;
}
}

// Ionic Design Checkbox Shapes
Expand Down
23 changes: 14 additions & 9 deletions core/src/components/checkbox/checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,25 +239,30 @@ export class Checkbox implements ComponentInterface {
* This element should only be rendered if hint text is set.
*/
private renderHintText() {
const { helperText, errorText, helperTextId, errorTextId } = this;
const { helperText, errorText, helperTextId, errorTextId, checked } = this;

/**
* undefined and empty string values should
* be treated as not having helper/error text.
*/
const hasHintText = !!helperText || !!errorText;
if (!hasHintText) {
const hasHelperText = !!helperText;
const hasErrorText = !!errorText && !checked;
if (!hasHelperText && !hasErrorText) {
return;
}

return (
<div class="checkbox-bottom">
<div id={helperTextId} class="helper-text" part="supporting-text helper-text">
{helperText}
</div>
<div id={errorTextId} class="error-text" part="supporting-text error-text">
{errorText}
</div>
{hasHelperText && (
<div id={helperTextId} class="helper-text" part="supporting-text helper-text">
{helperText}
</div>
)}
{hasErrorText && (
<div id={errorTextId} class="error-text" part="supporting-text error-text">
{errorText}
</div>
)}
</div>
);
}
Expand Down
12 changes: 12 additions & 0 deletions core/src/components/checkbox/test/states/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,18 @@ <h2>Focused, Unchecked</h2>
<h2>Focused, Checked</h2>
<ion-checkbox checked class="ion-focused">Enable Notifications</ion-checkbox>
</div>

<div class="grid-item">
<h2>Focused, Invalid</h2>
<ion-checkbox error-text="Error text" class="ion-invalid ion-focused">Enable Notifications</ion-checkbox>
</div>

<div class="grid-item">
<h2>Disabled, Invalid</h2>
<ion-checkbox disabled="true" error-text="Error text" class="ion-invalid"
>Enable Notifications
</ion-checkbox>
</div>
</div>
</ion-content>
</ion-app>
Expand Down
Loading