Skip to content

Conversation

klomlk
Copy link

@klomlk klomlk commented Sep 26, 2025

Purpose of this PR

Merge a working module for lambda client side scanner

Reference issues or tasks

...

Checklist

  • Build pass
  • Tests pass
  • Lint pass (pre-comit)
  • Commit convention respected

@npochic
Copy link

npochic commented Sep 26, 2025

The linter rejects the format of commit messages and pull request title.
Indeed they should follow this template: <type>: <message> (contribute doc).

Copy link

@npochic npochic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some files are marked as changed but I do not see the difference?

# Required variables
kms_key_arn = "arn:aws:kms:eu-west-3:992382519845:key/f4ab6c91-0a7d-4a32-8c11-8fdd4380888d"
aws_org_id = "o-yn7toj4ob7"
cur_output_bucket_name = "iroco-cur-bucket-toto"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cur_output_bucket_name = "iroco-cur-bucket-toto"
cur_output_bucket_name = "iroco-cur-bucket-example"

avoid toto?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the difference?

Comment on lines +5 to +14
kms_key_arn = "arn:aws:kms:eu-west-3:992382519845:key/02094aa9-afab-4e3c-84b2-8082380c66eb"
layer_bucket_storage = "iroco-test-sylvain-scrapper"
layer_bucket_key = "layers/helper-scripts.zip"
aws_org_id = "o-yn7toj4ob7"
cur_output_bucket_name = "iroco-cur-bucket"
cur_function_s3_key = "functions/cur-scanner.zip"
cur_function_s3_bucket = "iroco-test-sylvain-scrapper"
iroco2_api_endpoint = "https://api.iroco2.example.com"
iroco2_gateway_endpoint = "https://gateway.iroco2.example.com"
iroco2_api_key = "your-api-key-here"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

align =?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants