-
Notifications
You must be signed in to change notification settings - Fork 1
Cur Client scanner module #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The linter rejects the format of commit messages and pull request title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some files are marked as changed but I do not see the difference?
# Required variables | ||
kms_key_arn = "arn:aws:kms:eu-west-3:992382519845:key/f4ab6c91-0a7d-4a32-8c11-8fdd4380888d" | ||
aws_org_id = "o-yn7toj4ob7" | ||
cur_output_bucket_name = "iroco-cur-bucket-toto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cur_output_bucket_name = "iroco-cur-bucket-toto" | |
cur_output_bucket_name = "iroco-cur-bucket-example" |
avoid toto?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the difference?
kms_key_arn = "arn:aws:kms:eu-west-3:992382519845:key/02094aa9-afab-4e3c-84b2-8082380c66eb" | ||
layer_bucket_storage = "iroco-test-sylvain-scrapper" | ||
layer_bucket_key = "layers/helper-scripts.zip" | ||
aws_org_id = "o-yn7toj4ob7" | ||
cur_output_bucket_name = "iroco-cur-bucket" | ||
cur_function_s3_key = "functions/cur-scanner.zip" | ||
cur_function_s3_bucket = "iroco-test-sylvain-scrapper" | ||
iroco2_api_endpoint = "https://api.iroco2.example.com" | ||
iroco2_gateway_endpoint = "https://gateway.iroco2.example.com" | ||
iroco2_api_key = "your-api-key-here" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
align =
?
Purpose of this PR
Merge a working module for lambda client side scanner
Reference issues or tasks
...
Checklist