Implement UpdateMachine driver interface method
#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afritzler
changed the title
UpdateMachine driver interfaceUpdateMachine driver interface method
afritzler
force-pushed
the
enh/machine-update
branch
from
707b765 to
b2d2dca
Compare
afritzler
force-pushed
the
enh/machine-update
branch
2 times, most recently
from
e7f4116 to
c865467
Compare
afritzler
force-pushed
the
enh/machine-update
branch
from
f00038d to
f85a4df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
POC implementation of
UpdateMachinedriver method to updateServerClaimsin case of an in-place-update.Problem Statement:
In the current in-place update flow, the infrastructure resources are not being updated when an OS change in the Shoot spec happens for a respective worker group. This leads to a problem in a setup where you always want to netboot your
Serversvia a change in theServerClaimimage field.Proposed solution:
This PR leverages the newly added
UpdateMachineinterface method of the driver which is triggered whenever an in-place update is ready to being process. In this step, theUpdateMachinecall will figure out whichServerClaimis affected and will PATCH theimagefield of thatServerClaim./ref https://github.com/afritzler/machine-controller-manager/tree/enh/machine-update