-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ES] broken links #16695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES] broken links #16695
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @josunect. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in general, only a small question
content/es/_index.html
Outdated
@@ -97,7 +97,7 @@ <h1>Proveedores de Istio</h1> | |||
</div> | |||
|
|||
<div class="cta-container"> | |||
<a class="btn" href="/about/ecosystem#providers">Ver todos los proveedores</a> | |||
<a class="btn" href="/es/about/ecosystem#index">Ver todos los proveedores</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: why change it #providers
for #index
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, that is a mistake, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my question would be, do you need the /es/
? Do inline links not automatically get linked to the right localisation? I've only ever worked on en so I'm not sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was broken before; it was redirecting to the en
link for providers, so I'm assuming that they are not linked automatically. All the fixes in this PR I tested manually xD, so these were the ones that I found while I navigated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hey @craigbox, can we approve this PR to get it merged? |
/cherry-pick release-1.26 |
@fjglira: new pull request created: #16721 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Replace broken links:
Main page in Spanish:
Ref. #16684
Reviewers
https://deploy-preview-16695--preliminary-istio.netlify.app/latest/
https://deploy-preview-16695--preliminary-istio.netlify.app/latest/es/