Skip to content

Conversation

josunect
Copy link
Contributor

@josunect josunect commented Jul 22, 2025

Description

Replace broken links:
Main page in Spanish:

  • Ultimas noticias link in main page redirects to English version, it should be redirecting to here
  • Unete a la comunidad link on the main page redirects to the English version
  • Same with Aprende más link in the main page redirects to the English version
  • Lee nuestros casos de estudio in the main page redirects to the English version
  • Ver todos los proveedores link in the main page redirects to the English version
  • Editar esta pagina link in the main page redirects to the English version
  • Acerca de test in the header is in English (About)
  • Noticias link is broken
  • Error page when the link is broken has the headers in English
  • TODO: 404 redirecting to the english page for some reason

Ref. #16684

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

https://deploy-preview-16695--preliminary-istio.netlify.app/latest/
https://deploy-preview-16695--preliminary-istio.netlify.app/latest/es/

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 22, 2025
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been a while since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, our style guidelines,
    and the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be built with
    a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top-notch. We do spell checking, sanitize the Markdown, ensure all hyperlinks point to a
    valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    lint_istio.io entry in the status section. Click on the Details link to get a list of the
    problems with your PR. Fix those problems and push an update; this will automatically re-run the
    tests. Hopefully this time everything will be perfect!

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).
    To publish them sooner, add a cherrypick/release-x.xx label, where x.xx is the current
    release of Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Jul 22, 2025
@istio-testing
Copy link
Contributor

Hi @josunect. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@josunect josunect marked this pull request as ready for review July 22, 2025 15:48
@josunect josunect requested review from a team as code owners July 22, 2025 15:48
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 22, 2025
@josunect
Copy link
Contributor Author

cc @fjglira @ferhoyos

@fjglira
Copy link
Contributor

fjglira commented Jul 22, 2025

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jul 22, 2025
Copy link
Contributor

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general, only a small question

@@ -97,7 +97,7 @@ <h1>Proveedores de Istio</h1>
</div>

<div class="cta-container">
<a class="btn" href="/about/ecosystem#providers">Ver todos los proveedores</a>
<a class="btn" href="/es/about/ecosystem#index">Ver todos los proveedores</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: why change it #providers for #index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that is a mistake, good catch!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my question would be, do you need the /es/? Do inline links not automatically get linked to the right localisation? I've only ever worked on en so I'm not sure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was broken before; it was redirecting to the en link for providers, so I'm assuming that they are not linked automatically. All the fixes in this PR I tested manually xD, so these were the ones that I found while I navigated

Copy link
Contributor

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fjglira
Copy link
Contributor

fjglira commented Jul 24, 2025

Hey @craigbox, can we approve this PR to get it merged?

@istio-testing istio-testing merged commit 1728a83 into istio:master Jul 25, 2025
6 checks passed
@josunect josunect deleted the issue16684_broken_links branch July 25, 2025 06:08
@fjglira
Copy link
Contributor

fjglira commented Jul 30, 2025

/cherry-pick release-1.26

@istio-testing
Copy link
Contributor

@fjglira: new pull request created: #16721

In response to this:

/cherry-pick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants