Add unsubscribe method.

[devel-pa]

No description provided.

[itavy]

can you please put find on a new line?

[itavy]

please split on multiple lines. each property on a line

[itavy]

please first unsubscribe and then delete it from queueRoutingTable. it might have undesired side effects between deleting from routing table and actual subscribing; also if it fails to unsubscribe it will remain deleted from routing table

[itavy]

please use destructuring for function signature

[itavy]

since they are not reassigned use const instead of let

[itavy]

return a meaningful error. you can return index and consumer tag null, but don't rely on construction error of language (undefined as property throws error)

also in case of success (not found it is considered a success not an error, from routing table point of view) response should be consistent.

[itavy]

no need to test the prepare flow. subscribe should be tested before and no need to test it again

[itavy]

please assert that the actual connector unsubscribe was called

[itavy]

assert here that you have as cause the actual error trowed by the stub

[itavy]

these tests will need to be updated after the changes i pointed out

[itavy]

if this fails it will not be caught by catch and will throw a non standard error

[itavy]

please return here a specific error with cause as cause

in try block return null if consumerTag is undefined (not found)

element not found is a perfect response from this function. for actual case it is an error, but this is valid for the caller of getHandlerRefsByProperties. there can also be a check where you want to test if there is a handler associated for info provided and if it is not you need to do something else. by throwing error here you need to wrap it and do something on catch block.

[devel-pa]

I can throw one error when handler not found and one when index not found by consumerTag:

getHandlerRefsByProperties({
    queue,
    topic,
    exchange,
  }) {
    const handler = Object.values(this.handlers)
      .find(el =>
        el.queue === queue &&
        el.topic === topic &&
        el.exchange === exchange);

    if (handler) {
      if (handler.consumerTag) {
        const index = this.consumerTags[handler.consumerTag];
        if (index) {
          return {
            consumerTag: handler.consumerTag,
            index,
          };
        }
        throw Reflect.construct(IError, [{
          name:   'MQ_ROUTING_TABLE_UNKNOWN_CONSUMER_TAG',
          source: `${this.sourceIdentifier}.getHandlerRefsByProperties`,
        }]);
      }

      return {
        consumerTag: null,
        index:       null,
      };
    }

    throw Reflect.construct(IError, [{
      name:   'MQ_ROUTING_TABLE_UNKNOWN_HANDLER',
      source: `${this.sourceIdentifier}.getHandlerRefsByProperties`,
    }]);
  }
}