Skip to content

Less limited text-anchor attribute handling. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Less limited text-anchor attribute handling. #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions itext.tests/itext.svg.tests/itext/svg/renderers/impl/TSpanNodeRendererIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,12 @@ public virtual void TSpanTextAnchorFunctionalTest() {
ConvertAndCompare(SOURCE_FOLDER, DESTINATION_FOLDER, "textspan-textAnchor");
}

//Text-anchor test using transform attribute for X position
[NUnit.Framework.Test]
public virtual void TSpanTextAnchorTransformFunctionalTest() {
ConvertAndCompare(SOURCE_FOLDER, DESTINATION_FOLDER, "textspan-textAnchor-transform");
}

[NUnit.Framework.Test]
//TODO: update after DEVSIX-2507 and DEVSIX-3005 fix
[LogMessage(iText.StyledXmlParser.Logs.StyledXmlParserLogMessageConstant.UNKNOWN_ABSOLUTE_METRIC_LENGTH_PARSED
Expand Down
Binary file added ...svg/renderers/impl/TSpanNodeRendererIntegrationTest/cmp_textspan-textAnchor-transform.pdf
View file
Open in desktop
Binary file not shown.
144 changes: 144 additions & 0 deletions ...nderers/impl/TSpanNodeRendererIntegrationTest/textspan-textAnchor-transform.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
8 changes: 2 additions & 6 deletions itext/itext.svg/itext/svg/renderers/impl/TextSvgBranchRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,15 +411,11 @@ internal virtual float GetTextAnchorAlignmentCorrection(float childContentLength
String textAnchorValue = this.GetAttribute(SvgConstants.Attributes.TEXT_ANCHOR);
// Middle
if (SvgConstants.Values.TEXT_ANCHOR_MIDDLE.Equals(textAnchorValue)) {
if (xPos != null && xPos.Length > 0) {
textAnchorXCorrection -= childContentLength / 2;
}
textAnchorXCorrection -= childContentLength / 2;
}
// End
if (SvgConstants.Values.TEXT_ANCHOR_END.Equals(textAnchorValue)) {
if (xPos != null && xPos.Length > 0) {
textAnchorXCorrection -= childContentLength;
}
textAnchorXCorrection -= childContentLength;
}
}
return textAnchorXCorrection;
Expand Down