Skip to content

Merge hotfix 1.2.3 into develop - #65

Merged
turegjorup merged 10 commits into
developfrom
merge/1.2.3-into-develop
Oct 7, 2026
Merged

turegjorup merged 10 commits into
developfrom
merge/1.2.3-into-develop

Conversation

@turegjorup

@turegjorup turegjorup commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Merge hotfix 1.2.3 (#63) back into develop.

Changes

  • Merge tag 1.2.3: the app:apikeys:add command, its tests, README section and .gitignore entries.
  • CHANGELOG.md conflict resolved by keeping develop's [Unreleased] list and adding the [1.2.3] - 2026-10-07 section above [1.2.2].
  • Follow-up commit applying develop's stricter tooling to the new code (not present on main): Rector (final test class, $this->assert*, first-class callable, string cast, closure return type, boolean condition rewrite) and a PHPStan strict-rules fix (1 === preg_match(...)). No behaviour change.

Why

Gitflow: hotfixes merged to main must be merged back into develop so the next release includes them. Full test suite (265), PHPStan and Rector pass locally.

The 1.2.4 back-merge follows in a separate PR.

@turegjorup turegjorup self-assigned this Oct 7, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.58537% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.42%. Comparing base (4e3dcfc) to head (e2c915a).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/Command/ApiKeysAddCommand.php 86.58% 11 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #65      +/-   ##
=============================================
+ Coverage      72.89%   74.42%   +1.52%     
- Complexity       232      262      +30     
=============================================
  Files             29       30       +1     
  Lines            653      735      +82     
=============================================
+ Hits             476      547      +71     
- Misses           177      188      +11     
Flag Coverage Δ
unittests 74.42% <86.58%> (+1.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@turegjorup
turegjorup merged commit 4d41c1f into develop Oct 7, 2026
13 of 14 checks passed
@turegjorup
turegjorup deleted the merge/1.2.3-into-develop branch October 7, 2026 08:22
@turegjorup turegjorup changed the title Merge hotfix 1.2.3 into develop Merge hotfixes 1.2.3 and 1.2.4 into develop Oct 7, 2026
@turegjorup turegjorup changed the title Merge hotfixes 1.2.3 and 1.2.4 into develop Merge hotfix 1.2.3 into develop Oct 7, 2026
@turegjorup turegjorup mentioned this pull request Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants