Skip to content

when in expression is Reference to property or field then Route creation fail #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

when in expression is Reference to property or field then Route creation fail #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf8d7bc
when in expression is Reference to property or field then Route creat…
Jul 8, 2019
d608a45
simplifying
Jul 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions src/AspNet.Mvc.TypedRouting/LinkGeneration/ExpressionRouteHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ private ExpressionRouteValues ResolveLambdaExpression(
}
}

ApplyAdditionaRouteValues(additionalRouteValues, routeValues);
ApplyAdditionalRouteValues(additionalRouteValues, routeValues);

if (addControllerAndActionToRouteValues)
{
Expand Down Expand Up @@ -231,27 +231,12 @@ private IDictionary<string, object> GetRouteValues(
// Expression of type c => c.Action({const}) - value can be extracted without compiling.
value = ((ConstantExpression)expressionArgument).Value;
}
else if (expressionArgument.NodeType == ExpressionType.MemberAccess
&& ((MemberExpression)expressionArgument).Member is FieldInfo)
{
// Expression of type c => c.Action(id)
// Value can be extracted without compiling.
var memberAccessExpr = (MemberExpression)expressionArgument;
var constantExpression = (ConstantExpression)memberAccessExpr.Expression;
if (constantExpression != null)
{
var innerMemberName = memberAccessExpr.Member.Name;
var compiledLambdaScopeField = constantExpression.Value.GetType().GetField(innerMemberName);
value = compiledLambdaScopeField.GetValue(constantExpression.Value);
}
}
else
{
// Expresion needs compiling because it is not of constant type.
// Expression needs compiling because it is not of constant type.
var convertExpression = Expression.Convert(expressionArgument, typeof(object));
value = Expression.Lambda<Func<object>>(convertExpression).Compile().Invoke();
}

// We are interested only in not null route values.
if (value != null)
{
Expand All @@ -262,7 +247,7 @@ private IDictionary<string, object> GetRouteValues(
return result;
}

private static void ApplyAdditionaRouteValues(object routeValues, IDictionary<string, object> result)
private static void ApplyAdditionalRouteValues(object routeValues, IDictionary<string, object> result)
{
if (routeValues != null)
{
Expand Down