Repository navigation
Conversation
|
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information Contact @richardTingle (aka richtea) for guidance if required |
|
These screenshot test failures will be related to #2542 |
|
Closing because none of the requested changes were addressed. |
This PR refactors the
Uniformclass incom.jme3.shaderto improve code clarity, maintainability, and usage safety. Key changes include:setValue.Objects.equals.deleteNativeBufferswith explanatory comments.These updates make the
Uniformclass easier to understand, safer to use, and better documented for both users and maintainers.