Skip to content

Conversation

jasonacox
Copy link
Owner

This pull request adds automatic detection of the command type used by CoverDevice ("open"/"close" vs "on"/"off"), improving compatibility with different device models and reducing the need for manual configuration. It includes a manual override method, updates documentation and examples, and bumps the project version.

CoverDevice command detection and configuration:

  • Added lazy detection in CoverDevice to automatically determine whether to use "open"/"close" or "on"/"off" commands by checking device status on the first use, defaulting to "on"/"off" for backward compatibility (tinytuya/CoverDevice.py).
  • Includes set_cover_command_type(use_open_close=True) method to allow manual override of the detected command type (tinytuya/CoverDevice.py).

Documentation and examples:

  • Updated function signatures and notes in both the code and README.md to document the new command detection behavior and manual override method (tinytuya/CoverDevice.py, README.md). [1] [2]
  • Added a new example in the README.md demonstrating how to use CoverDevice with both automatic detection and manual override (README.md).

Closes #653

@Copilot Copilot AI review requested due to automatic review settings October 12, 2025 05:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the CoverDevice class by adding automatic detection of command types, allowing it to work with devices that use either "open"/"close" or "on"/"off" commands without manual configuration.

  • Added lazy command type detection that checks device status on first use
  • Implemented manual override method set_cover_command_type() for explicit control
  • Updated documentation and added usage examples

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tinytuya/core/core.py Version bump from 1.17.4 to 1.17.5
tinytuya/CoverDevice.py Added command detection logic, manual override method, and updated function signatures
RELEASE.md Added release notes for v1.17.5 describing the new CoverDevice features
README.md Updated CoverDevice documentation and added comprehensive usage examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cover Controls freezing up

1 participant