Skip to content

Improved Node.toString() #2026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions src/main/java/com_github_leetcode/Node.java
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

import java.util.ArrayList;
import java.util.List;
import java.util.StringJoiner;

@SuppressWarnings("java:S1104")
public class Node {
Expand All @@ -24,19 +23,32 @@ public Node(int val, List<Node> neighbors) {
this.neighbors = neighbors;
}

@Override
public String toString() {
StringJoiner result = new StringJoiner(",", "[", "]");
for (Node node : neighbors) {
StringBuilder result = new StringBuilder();
result.append("[");
for (int i = 0; i < neighbors.size(); i++) {
Node node = neighbors.get(i);
if (i > 0) {
result.append(",");
}
if (node.neighbors.isEmpty()) {
result.add(String.valueOf(node.val));
result.append(node.val);
} else {
StringJoiner result2 = new StringJoiner(",", "[", "]");
for (Node nodeItem : node.neighbors) {
result2.add(String.valueOf(nodeItem.val));
StringBuilder result2 = new StringBuilder();
result2.append("[");
for (int j = 0; j < node.neighbors.size(); j++) {
Node nodeItem = node.neighbors.get(j);
if (j > 0) {
result2.append(",");
}
result2.append(nodeItem.val);
}
result.add(result2.toString());
result2.append("]");
result.append(result2.toString());
}
}
result.append("]");
return result.toString();
}
}
42 changes: 23 additions & 19 deletions src/main/java/com_github_leetcode/random/Node.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com_github_leetcode.random;

import java.util.StringJoiner;

@SuppressWarnings("java:S1104")
public class Node {
public int val;
Expand All @@ -12,34 +10,40 @@ public Node(int val) {
this.val = val;
}

@Override
public String toString() {
StringJoiner result = new StringJoiner(",", "[", "]");
StringJoiner result2 = new StringJoiner(",", "[", "]");
result2.add(String.valueOf(val));
if (random == null) {
result2.add("null");
StringBuilder result = new StringBuilder();
result.append("[");
result.append("[");
result.append(this.val);
result.append(",");
if (this.random == null) {
result.append("null");
} else {
result2.add(String.valueOf(random.val));
result.append(this.random.val);
}
result.add(result2.toString());
Node curr = next;
result.append("]");
Node curr = this.next;
while (curr != null) {
StringJoiner result3 = new StringJoiner(",", "[", "]");
result3.add(String.valueOf(curr.val));
result.append(",");
result.append("[");
result.append(curr.val);
result.append(",");
if (curr.random == null) {
result3.add("null");
result.append("null");
} else {
int randomIndex = 0;
Node curr2 = this;
while (curr2.next != null && curr2 != curr.random) {
randomIndex += 1;
curr2 = curr2.next;
Node indexFinder = this;
while (indexFinder.next != null && indexFinder != curr.random) {
randomIndex++;
indexFinder = indexFinder.next;
}
result3.add(String.valueOf(randomIndex));
result.append(randomIndex);
}
result.add(result3.toString());
result.append("]");
curr = curr.next;
}
result.append("]");
return result.toString();
}
}
Loading