Skip to content

Conversation

@Thakor-Yashpal
Copy link
Contributor

Resolves #<issue_number_goes_here>

Reference

Checklist

  • [] I have read the Contribution Guidelines and used pre-commit hooks to format this commit.
  • [] I have added all the necessary unit tests for my change. (run_model.py for model usage, test_outputs.py and/or model_validation_colab.ipynb for quality).
  • [] (If using an LLM) I have carefully reviewed and removed all superfluous comments or unneeded, commented-out code. Only necessary and functional code remains.
  • [] I have signed the Contributor License Agreement (CLA).

@jenriver
Copy link
Member

jenriver commented Nov 20, 2025

Hello Thakor, it'd be really cool to have a CLIP implementation here. It seems there's no file changes here, did you forget to push commit?

Related issue: #72

@Thakor-Yashpal
Copy link
Contributor Author

Hello Thakor, it'd be really cool to have a CLIP implementation here. It seems there's no file changes here, did you forget to push commit?

Relaetd issue: #72

I had pushed the initial code earlier, but the implementation wasn’t up to the quality I wanted, so I removed those files. I’m making the necessary improvements now and will push the updated files on Wednesday.

@Iamleos
Copy link

Iamleos commented Dec 4, 2025

When CLIP will be merged?

@@ -0,0 +1,185 @@
from typing import Any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be entirely used in tests/ insetad to follow pattern in https://github.com/jax-ml/bonsai/blob/main/CONTRIBUTING.md#contributing-a-model?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants