Update dependency gh-pages to v5 [SECURITY] #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 740d9ed in 1 minute and 16 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. package.json:8
- Draft comment:
Confirm that updating gh-pages to ^5.0.0 is intentional. Note that v5 introduces a breaking change: its publish function now always returns a promise, so if you use it programmatically, ensure your async handling is updated. Also, verify that your deployment environment meets the Node version requirements (v12+). - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% This is a dependency version change. Our rules explicitly state "Do NOT comment on dependency changes" and "Do NOT ask the PR author to confirm their intention". The comment starts with "Confirm that..." which is exactly what we're told to avoid. The breaking change mentioned only affects programmatic usage, but the package.json shows it's only used via CLI. Maybe the breaking changes in gh-pages v5 could cause deployment failures that would be hard to debug later? The rules are very clear about not commenting on dependency changes, regardless of potential impact. Plus, the breaking change mentioned doesn't affect CLI usage, which is how gh-pages is used here. Delete this comment as it violates multiple rules: it's about dependency changes and asks for confirmation of intent.
Workflow ID: wflow_KIoqfRntQ4Utrv2E
You can customize 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming soon: The Renovate bot (GitHub App) will be renamed to Mend. PRs from Renovate will soon appear from 'Mend'. Learn more here.
This PR contains the following updates:
^1.0.0->^5.0.0GitHub Vulnerability Alerts
CVE-2022-37611
Prototype pollution vulnerability in tschaub gh-pages via the partial variable in util.js.
Release Notes
tschaub/gh-pages (gh-pages)
v5.0.0Compare Source
Potentially breaking change: the
publishmethod now always returns a promise. Previously, it did not return a promise in some error cases. This should not impact most users.Updates to the development dependencies required a minimum Node version of 14 for the tests. The library should still work on Node 12, but tests are no longer run in CI for version 12. A future major version of the library may drop support for version 12 altogether.
v4.0.0Compare Source
This release doesn't include any breaking changes, but due to updated development dependencies, tests are no longer run on Node 10.
v3.2.3Compare Source
v3.2.2Compare Source
v3.2.1Compare Source
v3.2.0Compare Source
This release updates a few development dependencies and adds a bit of documentation.
v3.1.0Compare Source
The cache directory used by
gh-pagesis nownode_modules/.cache/gh-pages. If you want to use a different location, set theCACHE_DIRenvironment variable.v3.0.0Compare Source
Breaking changes:
None really. But tests are no longer run on Node < 10. Development dependencies were updated to address security warnings, and this meant tests could no longer be run on Node 6 or 8. If you still use these Node versions, you may still be able to use this library, but be warned that tests are no longer run on these versions.
All changes:
v2.2.0Compare Source
--no-historyflag not to preserve deploy history (@dplusic)v2.1.1Compare Source
v2.1.0Compare Source
v2.0.1Compare Source
v2.0.0Compare Source
Breaking changes:
Requires Node 6 and above. If you require support for Node 4, stick with v1.2.0.
The git user for commits is determined by running
git config user.nameandgit config user.emailin the current working directory whengh-pagesis run. Ideally, this is what you want. In v1, the git user was determined based on thegh-pagesinstall directory. If the package was installed globally, the git user might not have been what you expected when running in a directory with a locally configured git user.#264 - Better user handling (thanks @holloway for getting this going and @nuklearfiziks and @paulirish for pushing it over the edge)
#263 - Infra: newer syntax and upgrade deps to latest stable versions (@AviVahl)
v1.2.0Compare Source
v1.1.0Compare Source
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.