-
-
Notifications
You must be signed in to change notification settings - Fork 144
cleanup: remove blob storage upload from publishReports
#860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dduportal
merged 8 commits into
jenkins-infra:master
from
lemeurherve:issue855-remove-duplicated-blob-storage-upload-from-publishreports
Oct 6, 2025
Merged
cleanup: remove blob storage upload from publishReports
#860
dduportal
merged 8 commits into
jenkins-infra:master
from
lemeurherve:issue855-remove-duplicated-blob-storage-upload-from-publishreports
Oct 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
May 30, 2024
…load-from-publishreports
…load-from-publishreports
…load-from-publishreports
…load-from-publishreports
Update: we are still delaying this PR as it could have some impacts we are not ready to handle yet |
…load-from-publishreports
8 tasks
…load-from-publishreports
dduportal
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging as preliminary part of jenkins-infra/helpdesk#4821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the blob storage upload from
publishReports
as this blob storage isn't used anymore.As the
az storage file upload-batch
command doesn't have any timout parameter and as there is no call topublishReports
with a specific timeout across @jenkinsci & @jenkins-infra repositories, I removed all code from the function and the tests related to timeout.Ref:
publishReports
#855 (to be completed after this PR by a cleanup of the related blob storage)failIfEmpty
parameter #853 (comment)