Remove dead code for no-longer-supported baselines#137
Merged
kuisathaverat merged 1 commit intojenkinsci:masterfrom Jul 21, 2019
Merged
Remove dead code for no-longer-supported baselines#137kuisathaverat merged 1 commit intojenkinsci:masterfrom
kuisathaverat merged 1 commit intojenkinsci:masterfrom
Conversation
kuisathaverat
approved these changes
Jul 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was perusing the source tree while debugging an unrelated issue and came across this TODO. The TODO was added in #70. At the time, this plugin's baseline was 1.625, so #70 needed a way to support Jenkins core versions both with JENKINS-43786 (i.e., 2.103 and later) and without it. This plugin's baseline is now 2.150.1, which does contain JENKINS-43786. So now the logic to support older baselines is dead code that can be removed.
To test this change, I ran
mvn clean packagelocally. It passed. Please let me know if there is any additional testing I should do.