The skipping of null values during array processing has been removed #5241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was the old code an optimization, which is not working anymore? |
|
Apart from code format errors, no new issues have been introduced in ci. The deleted code seems to skip whenever an empty value is encountered during the array processing, without any further purpose. |
inconsistent with the mainstream js engine behavior, has been removed JerryScript-DCO-1.0-Signed-off-by: tangbin [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #5026
Signevior of skipping null values during array processing, which was inconsistent with the mainstream js engine behavior, has been removed.
JerryScript-DCO-1.0-Signed-off-by: tangbin [email protected]