Limit pipeset (pre-)rendering #4906
Open
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Limit the number of (pre-)rendered pipesets which are visible when rendering a git graph to the actual currently visible number of commits. This is important for large repositories with a large number of commits when scrolling past the first 200 commits, which currently triggers a load of the complete commit history[1]. If this happens and the git graph rendering is enabled a potentially large number of pipes (~138k for the linux kernel) is allocated. [1]: https://github.com/jesseduffield/lazygit/blob/d56a9cf73e6a34550e42d2627c011c4b73e5a975/pkg/gui/controllers/local_commits_controller.go#L1265 Signed-off-by: Stefan Kerkmann <[email protected]>
|
This makes memory usage much worse. The pipe set cache stores pipe sets based on commit hash plus number of commits, so as you move the selection around, you will end up with tons of duplicates of the pipe set data in the cache. And that data needs to be recalculated all the time as you scroll down, which makes navigating the list super sluggish once you scroll down enough. I know that we have huge problems with memory usage and performance in large repos, but this is not a way to improve this I'm afraid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Limit the number of (pre-)rendered pipesets which are visible when rendering a git graph to the actual currently visible number of commits. This is important for large repositories with a large number of commits when scrolling past the first 200 commits, which currently triggers a load of the complete commit history1. If this happens and the git graph rendering is enabled a potentially large number of pipes (~138k for the linux kernel) is allocated.
Please check if the PR fulfills these requirements
go generate ./...)