Skip to content

Issue #13548 - Improved HTTP2Connection dump information #13591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2025
Merged

Issue #13548 - Improved HTTP2Connection dump information #13591

merged 2 commits into from
Sep 15, 2025

Conversation

znight1020
Copy link
Contributor

@znight1020 znight1020 commented Sep 14, 2025 •
edited
Loading

Closes #13548

Summary

This PR enhances the HTTP2Session.dump() functionality to include a snapshot of the session's SETTINGS state.
With this change, the dump now provides a clear view of both local and remote settings, for example:

oejh2si.HTTP2ServerSession@2642bcb6...
   +> streams size=0
   +> local settings size=2
   |  +> 3: 124
   |  +> 5: 32768
   +> remote settings size=1
      +> 3: 128

The dump shows the current merged snapshot (the last known value for each parameter), not just the most recent SETTINGS frame.

RFC 9113#6.5 the value of a SETTINGS parameter is the last value that is seen by a receiver.

Changes

  • HTTP2Session now tracks the current state of local and remote SETTINGS.
    • The dump() has been enhanced to include these tracked settings.
  • The settings map is updated only on non-ACK SETTINGS frames.
    • ACK-only frames and empty non-ACK frames are treated as no-ops, as they do not alter the state.

@znight1020 znight1020 force-pushed the jetty-12.1.x-13548/improvedHTTP2ConnectionDump branch from 11e53f4 to d9de2cd Compare September 14, 2025 15:19
@znight1020 znight1020 mentioned this pull request Sep 14, 2025
Closed
@znight1020 znight1020 force-pushed the jetty-12.1.x-13548/improvedHTTP2ConnectionDump branch from d9de2cd to f7bcc7f Compare September 14, 2025 20:03
sbordet
sbordet requested changes Sep 15, 2025
View reviewed changes
@znight1020 znight1020 force-pushed the jetty-12.1.x-13548/improvedHTTP2ConnectionDump branch from 5384f1e to 56974f7 Compare September 15, 2025 20:08
@znight1020 znight1020 requested a review from sbordet September 15, 2025 20:11
@znight1020
Updates from review
cd2a310 
Signed-off-by: 이현수 <[email protected]>
@znight1020 znight1020 force-pushed the jetty-12.1.x-13548/improvedHTTP2ConnectionDump branch from 56974f7 to cd2a310 Compare September 15, 2025 20:45
sbordet
sbordet approved these changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@znight1020 thanks!

@znight1020
Copy link
Contributor Author

@sbordet All set. Thanks for your patience and guidance!

@sbordet sbordet merged commit 880e79d into jetty:jetty-12.1.x Sep 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved HTTP2Connection dump information
2 participants
@znight1020 @sbordet