Fix WaitForTextToBePresentInElement to throw TimeoutException instead of returning false #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the fix from MAUI PR #31218 to align the behavior of
WaitForTextToBePresentInElement
with other wait methods in the library.Problem
The
WaitForTextToBePresentInElement
method was silently returningfalse
when the expected text was not found within the timeout period, instead of throwing aTimeoutException
like other wait methods. This caused tests to pass silently when they should fail, leading to false positive test results.Solution
The method now throws a
TimeoutException
with a descriptive message when the timeout is reached, aligning with the behavior of other wait methods likeWaitForElement
,WaitForNoElement
, etc.Changes
return false;
on timeoutthrow new TimeoutException($"Timed out waiting for text '{text}' to be present in element with automation id '{automationId}'.");
This change ensures that UI tests fail properly when expected conditions are not met, preventing false positive test results while maintaining backward compatibility since existing usage patterns don't typically check the return value of wait methods.
Fixes #58.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.