Mechanize doesn't support basic proxy authorization through https calls. #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls. This commit ports the https://hg.python.org/cpython/rev/10970f64ba33/ issue to urllib2 fork. More details can be found at https://bugs.python.org/issue7291. I've tested the code with python 2.7.6 and ran the unittests.
|
Thank you for your contribution to mechanize! Following the process in #117, future work on mechanize will be occurring here: Please re-file your PR there (where it will get attention, and hopefully merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ports the https://hg.python.org/cpython/rev/10970f64ba33/ issue to urllib2 fork. More details can be found at https://bugs.python.org/issue7291. I've tested the code with python 2.7.6 and ran the unittests. This changes will work assuming that the fix for httplib is included in python standard lib.
I've modified the ullib2_fork to forward the headers to the proxy tunnel. By default the headers were sent to the target server instead of proxy server. This should not be a problem after porting the commit from the above bug. Please note that fix for https://bugs.python.org/issue7291 was scattered through httplib and urllib2. Since for python 2.6.4 and above the standard httplib is used, there was no need for full back-port.