Skip to content

Conversation

javuto
Copy link
Collaborator

@javuto javuto commented May 29, 2025

Using golang release 1.24.3 which includes some important security fixes:

go1.24.3 (released 2025-05-06) includes security fixes to the os package, as well as bug fixes to the runtime, the compiler, the linker, the go command, and the crypto/tls and os packages.

More information in the Go 1.24.3 milestone

@javuto javuto requested a review from Copilot May 29, 2025 10:53
@javuto javuto added dependencies Dependencies related issues go Pull requests that update Go code labels May 29, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Bumps the Go version from 1.24.2 to 1.24.3 across the module, install scripts, Dockerfiles, workflows, and examples to include security and bug fixes from Go 1.24.3.

  • Update go.mod to require Go 1.24.3
  • Adjust install script and Dockerfiles to fetch Go 1.24.3
  • Refresh GitHub workflows and action defaults for Go 1.24.3

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updated Go directive to 1.24.3
deploy/lib.sh Updated install script comment & version var
deploy/docker/dockerfiles/Dockerfile-dev-* Bumped ARG default to Go 1.24.3
.github/workflows/*.yml Updated GOLANG_VERSION env to 1.24.3
.github/actions/*/action.yml Updated default golang_version to 1.24.3
.env.example Bumped GOLANG_VERSION to 1.24.3
Comments suppressed due to low confidence (3)

deploy/lib.sh:408

  • [nitpick] Consider making the install function version-agnostic (e.g., rename install_go_24 to install_go) or accept a version parameter to avoid renaming for each patch bump.
# Install go 1.24.3 from tgz

.github/workflows/build_and_test_pr.yml:8

  • [nitpick] The Go version is repeated across multiple workflows and Dockerfiles; consider centralizing it in one config or shared variable to reduce duplication and risk of mismatches.
GOLANG_VERSION: 1.24.3

.env.example:13

  • [nitpick] Update project documentation or README to note the new minimum required Go version (1.24.3) so contributors are aware of the bump.
GOLANG_VERSION=1.24.3

@javuto javuto merged commit b62b250 into main May 29, 2025
54 checks passed
@javuto javuto deleted the go-release-1-24-3 branch May 29, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies related issues go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant