Skip to content

remove semicolons for consistency #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove semicolons for consistency #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0a054e
remove semicolons for consistency
Aug 10, 2017
461e172
add spacing to render headers on Github properly
Aug 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ Be it a bug fix, new feature, [documentation](/docs), or tests—we love pull re
[How to Contribute to an Open Source Project on GitHub](https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github).

<a name="bug"/>

## Found a Bug?

Look through the GitHub issues for bugs. Anything tagged with "bug" is open to whoever wants to implement it. If you'd like to report a bug, please provide a reproducible test case. If possible, submit a Pull Request with a failing test.

<a name="pr"/>

## Making a Pull Request?
The following guidelines will make your pull request easier to merge. So please, read on.

Expand Down Expand Up @@ -41,6 +43,7 @@ npm test
Please be patient when your changes aren't merged immediately.

<a name="hacking"/>

## Hacking

Unfortunately, React Native packager does not support symlinking so you cannot use [`npm link`](https://docs.npmjs.com/cli/link) when hacking on this library. You can learn more about that, [here](https://productpains.com/post/react-native/symlink-support-for-packager/).
Expand All @@ -54,14 +57,17 @@ npm run watch
This will automatically watch the `modules` directory and sync your changes into `examples/Aviato/node_modules` every time something changes.

<a name="repo-format"/>

## Flat Repository Format
This project uses a flat repository structure. All source code is placed directly into `modules` directory. The main reason is that both `history` and `react-router` source repositories follow this convention and hacking on this library means hacking on those two as well. Mirroring the conventions used in those repos should make it easier to connect the pieces together.

<a name="feedback"/>

## Feedback

Feedback is always welcome. The best way to send feedback is to file an issue. If you are proposing a feature, explain in detail how it would work.

<a name="license"/>

## License
All pull requests that get merged will be made available under [the MIT license](https://github.com/jmurzy/react-router-native/blob/master/LICENSE.md), as the rest of the repository.
6 changes: 3 additions & 3 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Redux is supported via [react-router-redux](https://github.com/reactjs/react-rou
import React from 'react'
import { createStore, combineReducers, applyMiddleware } from 'redux'
import { Provider } from 'react-redux'
import { Router, nativeHistory } from 'react-router-native';
import { Router, nativeHistory } from 'react-router-native'
import { syncHistoryWithStore, routerReducer } from 'react-router-redux'

import reducers from '<project-path>/reducers'
Expand All @@ -62,7 +62,7 @@ const routes = (
/* ... */
</Router>
</Provider>
);
)

AppRegistry.registerComponent('YourApp', () => () => routes);
AppRegistry.registerComponent('YourApp', () => () => routes)
```