[c2cpg] Refactor AST creation for functions, types, fields - #5895
Merged
Merged
Conversation
- Fix typeRefIdStack usage and related usage in type AST creation; stop producing standalone TypeRef nodes under TypeDecls. - Improve handling of unresolved/problem bindings: treat IProblemBinding like IFunction so we can still create proper method fullNames and avoid placing Unknown expression nodes directly under TypeDecls. - Revise fieldAccesses to produce nested call ASTs with FieldIdentifier nodes for qualified names (supports multiple :: parts correctly). - Adjust unknown node logging: do not generate Unknown nodes for unparsed nodes under TypeDecls and add a clearer not-parsed message suggesting --with-include-auto-discovery. - Update FunctionDeclNodePass to use fullNameExact when querying typeDecls. - Update tests. Fixes: ShiftLeftSecurity/codescience#8804
max-leuthaeuser
force-pushed
the
max/issue8804
branch
from
March 25, 2026 06:49
636cfe0 to
3a12bb9
Compare
Resolved import conflicts in c2cpg: - AstCreator.scala: added AstCreationPass import, split x2cpg imports - CustomFileContentProvider.scala: split scanner imports, removed unused LoggerFactory - AstCreationPass.scala: deduplicated imports, removed CGlobal, split grouped imports - PreprocessorPass.scala: removed CGlobal import, split grouped parser imports
ml86
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeRefIdStackusage and related usage in type AST creation; stop producing standalone TypeRef nodes under TypeDecls.::parts correctly).Fixes: https://github.com/ShiftLeftSecurity/codescience/issues/8804