Skip to content

add support for [email protected] #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add support for [email protected] #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee3cf16
add support for [email protected]
maximgladkov Apr 1, 2020
5372ca6
add dummy react method
maximgladkov Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/src/main/java/com/reactlibrary/ThreadBaseReactPackage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import com.facebook.react.devsupport.JSCHeapCapture;
import com.facebook.react.modules.appstate.AppStateModule;
import com.facebook.react.modules.core.ExceptionsManagerModule;
import com.facebook.react.modules.core.Timing;
import com.facebook.react.modules.core.TimingModule;
import com.facebook.react.modules.debug.SourceCodeModule;
import com.facebook.react.modules.intent.IntentModule;
import com.facebook.react.modules.network.NetworkingModule;
Expand Down Expand Up @@ -37,7 +37,7 @@ public List<NativeModule> createNativeModules(ReactApplicationContext catalystAp
new AndroidInfoModule(catalystApplicationContext),
new ExceptionsManagerModule(reactInstanceManager.getDevSupportManager()),
new AppStateModule(catalystApplicationContext),
new Timing(catalystApplicationContext, reactInstanceManager.getDevSupportManager()),
new TimingModule(catalystApplicationContext, reactInstanceManager.getDevSupportManager()),
new UIManagerStubModule(catalystApplicationContext),
new SourceCodeModule(catalystApplicationContext),
new JSCHeapCapture(catalystApplicationContext),
Expand All @@ -49,7 +49,7 @@ public List<NativeModule> createNativeModules(ReactApplicationContext catalystAp
new VibrationModule(catalystApplicationContext),
new WebSocketModule(catalystApplicationContext),
new ThreadSelfModule(catalystApplicationContext),
new DevSettingsModule(reactInstanceManager.getDevSupportManager())
new DevSettingsModule(catalystApplicationContext, reactInstanceManager.getDevSupportManager())
);
}

Expand Down
5 changes: 5 additions & 0 deletions android/src/main/java/com/reactlibrary/UIManagerStubModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import com.facebook.react.bridge.OnBatchCompleteListener;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;

public class UIManagerStubModule extends ReactContextBaseJavaModule implements OnBatchCompleteListener {

Expand All @@ -19,4 +20,8 @@ public String getName() {
public void onBatchComplete() {

}

@ReactMethod
public void dummy() {
}
}