Add Unit Tests #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I don't know if you wanted these but I wanted to tinker with the code and I prefer to have unit tests before doing so. |
kalisjoshua
force-pushed
the
testing-units
branch
from
f5d479f to
0c4ea84
Compare
kalisjoshua
force-pushed
the
testing-units
branch
from
cab6262 to
bf4ee7b
Compare
Author
|
ping |
Owner
|
Sorry, been super busy. TBH I never use automated testing (never have in 38 years of developing). It's highly unlikely ikely that I would maintain them or even run them. |
Owner
|
That said, I'll try and find some time for a proper look, and decide what to do. I think the code has moved on somewhat since you wrote the tests too |
Author
|
No worries or pressure. I wanted some tests for myself because I wanted to hack on your solution but wanted to be sure that I wasn't missing any functionality. No rush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.