Support asynchronous callbacks for CustomParameter #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youssef-t
force-pushed
the
steps_parameters_async_evaluation
branch
from
64d46b0 to
0591c3d
Compare
youssef-t
force-pushed
the
steps_parameters_async_evaluation
branch
from
0bd1e73 to
d10afe9
Compare
|
In addition to the feature introduced in the PR (evaluating parameters with asynchronous callbacks), I did the following things:
I would love to hear from you if there is anything that should be changed. Thank you |
youssef-t
added a commit
to youssef-t/flutter_gherkin
that referenced
this pull request
Nov 17, 2023
This version of dart_gherkin is introduced while waiting for this PR to be merged jonsamwell/dart_gherkin#71
|
Approve and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This a feature introduced for the following issue: #70
I think it would be more flexible to accept also asynchronous callbacks to evaluate steps parameters
Thank you