Skip to content

Fix incorrect usage example #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix incorrect usage example #25

wants to merge 1 commit into from

Conversation

Lchemist
Copy link

isPlainObject(Object.create(null)) is supposed to be true

windusayles
windusayles approved these changes Feb 10, 2022
View reviewed changes
Copy link

@windusayles windusayles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct, creating an object from null creates an element with typeof object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@windusayles windusayles windusayles approved these changes

@Graysonbarton Graysonbarton Graysonbarton approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lchemist @windusayles @Graysonbarton