Conversation
Author
|
good catch |
alikon
approved these changes
Jan 12, 2026
|
When I think about it, that's not the right fix. Better option would actually be to simply release a new package with the downgraded version in the installer script which only took place after the release. |
|
Thank you very much @Razzo1987 - good catch. We (@exlemor and me) have tested the version on Joomla 5.4 now and prepared a new release. I'm closing here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this line of code:
patchtester/administrator/components/com_patchtester/script.php
Line 34 in 48b5952
it becomes impossible to install patchtester 5.0.0 on Joomla versions earlier than 6.0, so the XML is wrong (and indeed I can no longer install it on Joomla 5 starting from the update server)