Skip to content

Changes in migrations for 5.4.0-alpha3 #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2025

Conversation

muhme
Copy link
Contributor

@muhme muhme commented Jul 18, 2025

PR Type

Documentation


Description

  • Update migration documentation for Joomla 5.4.0-alpha3

  • Add new deprecations for UCM system and Random Image Module

  • Expand automated core updates feature descriptions

  • Include additional language string deprecations


Diagram Walkthrough

flowchart LR
  A["Migration Docs"] --> B["New Deprecations"]
  A --> C["New Features"]
  B --> D["UCM System"]
  B --> E["Random Image Module"]
  B --> F["Language Strings"]
  C --> G["Automated Updates"]
  C --> H["Filter Options"]
Loading

File Walkthrough

Relevant files
Documentation
new-deprecations.md
Expand deprecations documentation with new entries             

migrations/53-54/new-deprecations.md

  • Add Random Image Module deprecations with method replacements
  • Expand UCM system deprecation description with better formatting
  • Include three new language string deprecations with replacements
  • Improve formatting and structure throughout document
+34/-15 
new-features.md
Enhance new features documentation with descriptions         

migrations/53-54/new-features.md

  • Add detailed description for Automated Core Updates feature
  • Include additional PRs for automated updates functionality
  • Add descriptions for 'None' filter options and user-friendly links
  • Update version scope to include alpha3 features
+17/-4   

Copy link
Contributor

qodo-merge-pro bot commented Jul 18, 2025

PR Reviewer Guide 🔍

(Review updated until commit 315b434)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Formatting Issue

The Random Image Module section has inconsistent formatting with missing method class context and unclear deprecation guidance compared to other sections.

### Random Image Module

[45648](https://github.com/joomla/joomla-cms/pull/45648) – Convert mod_random_image to service provider

- ❌ Avoid using the `getRandomImage()` static method.
  - ✅ Instead use the non-static `getImage()` method.
- ❌ Avoid using the `getImages()` static method.
  - ✅ Instead use the non-static `getImagesFromFolder()` method.
- ❌ Avoid using the `getFolder()` static method.
  - ✅ Instead use the non-static `getSanitizedFolder()` method.
Duplicate Entry

The same PR link 45318 is listed twice with identical descriptions, which appears to be a copy-paste error.

* [45318](https://github.com/joomla/joomla-cms/pull/45318) Added a link to more easily open the
  'System – Maintenance – Database' view from the Pre-Update Check.
* [45318](https://github.com/joomla/joomla-cms/pull/45318) Added a link to more easily open the
  'Mail Templates' view from the Update Notification.

@muhme
Copy link
Contributor Author

muhme commented Jul 18, 2025

@richard67 please check and merge

Copy link
Contributor

qodo-merge-pro bot commented Jul 18, 2025

PR Code Suggestions ✨

Latest suggestions up to 315b434
Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Add class name context

The deprecation notice lacks the class name context, making it unclear which
class contains these methods. Include the full class name to help developers
identify the exact methods being deprecated.

migrations/53-54/new-deprecations.md [35-40]

-- ❌ Avoid using the `getRandomImage()` static method.
+- ❌ Avoid using the `ModRandomImageHelper::getRandomImage()` static method.
   - ✅ Instead use the non-static `getImage()` method.
-- ❌ Avoid using the `getImages()` static method.
+- ❌ Avoid using the `ModRandomImageHelper::getImages()` static method.
   - ✅ Instead use the non-static `getImagesFromFolder()` method.
-- ❌ Avoid using the `getFolder()` static method.
+- ❌ Avoid using the `ModRandomImageHelper::getFolder()` static method.
   - ✅ Instead use the non-static `getSanitizedFolder()` method.
  • Apply / Chat
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly identifies that the class name is missing for the deprecated methods, and adding it significantly improves the clarity of the documentation.

Low
  • Update

Previous suggestions

✅ Suggestions up to commit cff5d48
CategorySuggestion                                                                                                                                    Impact
General
Add missing class context

The deprecation notice lacks the class name context, making it unclear which
class contains these methods. Include the full class name to help developers
identify exactly which methods are being deprecated.

migrations/53-54/new-deprecations.md [35-40]

-- ❌ Avoid using the `getRandomImage()` static method.
+- ❌ Avoid using the `ModRandomImageHelper::getRandomImage()` static method.
   - ✅ Instead use the non-static `getImage()` method.
-- ❌ Avoid using the `getImages()` static method.
+- ❌ Avoid using the `ModRandomImageHelper::getImages()` static method.
   - ✅ Instead use the non-static `getImagesFromFolder()` method.
-- ❌ Avoid using the `getFolder()` static method.
+- ❌ Avoid using the `ModRandomImageHelper::getFolder()` static method.
   - ✅ Instead use the non-static `getSanitizedFolder()` method.
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly points out that the class name is missing for the deprecated methods, and adding it improves the clarity and precision of the documentation.

Low

@muhme muhme marked this pull request as draft July 18, 2025 13:13
@muhme
Copy link
Contributor Author

muhme commented Jul 18, 2025

Added at least one sentence for each feature as qodo sugested.

@muhme muhme marked this pull request as ready for review July 18, 2025 13:35
@richard67 richard67 merged commit b547241 into joomla:main Jul 18, 2025
2 checks passed
@richard67
Copy link
Member

Thanks.

@muhme muhme deleted the migrations-5.4.0-alpha3 branch July 18, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants