Skip to content

Conversation

@Akshay10258
Copy link

@Akshay10258 Akshay10258 commented Oct 23, 2025

User description

This pull request corrects the date format example in the Calendar Field documentation page (#543 ).

The previous example used MySQL-style placeholders (%i and %s), which are invalid in PHP date formatting.

Using %i and %s would not render correctly when interpreted by PHP functions (e.g., strftime, date_format).

Correcting it to %M and %S ensures consistency with PHP’s date formatting standards and prevents confusion for developers referencing this documentation.

Details of the Change :
Before change :

%Y-%m-%d %H:%i:%s

After change :

%Y-%m-%d %H:%M:%S

PR Type

Documentation


Description

  • Corrects invalid PHP date format placeholders in calendar field documentation

  • Changes MySQL-style %i and %s to valid PHP format %M and %S

  • Ensures consistency with PHP date formatting standards


Diagram Walkthrough

flowchart LR
  A["MySQL Format<br/>%H:%i:%s"] -- "Corrected to" --> B["PHP Format<br/>%H:%M:%S"]
  B -- "Applied to" --> C["Calendar Field Doc"]
Loading

File Walkthrough

Relevant files
Documentation
calendar.md
Correct PHP date format placeholders in example                   

docs/general-concepts/forms-fields/standard-fields/calendar.md

  • Updated date format example from '%Y-%m-%d %H:%i:%s' to '%Y-%m-%d
    %H:%M:%S'
  • Replaced invalid MySQL-style time placeholders (%i, %s) with valid PHP
    equivalents (%M, %S)
  • Maintains consistency with PHP date formatting standards in
    documentation
+1/-1     

@qodo-merge-pro
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🔴
No security impact

Description: None found; the change updates a documentation string example only and introduces no
executable code.
calendar.md [22-22]

Referred Code
  - If showtime is true then you will need to include some time fields, for example, '%Y-%m-%d %H:%M:%S'.
- **filter** (optional) is time zone to be used. There are two main values: "server_utc" and "user_utc". The first one is server time zone and the later is user time zone as configured in global configuration and user information respectively. There is also a value of none which must be used if the server time zone is set to something other than UTC and showtime is false.
Ticket Compliance
🟢
🎫 #543
🟢 Correct the calendar field documentation to replace the incorrect time format example
"%Y-%m-%d %H:%i:%s" with the correct "%Y-%m-%d %H:%M:%S".
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant