-
Notifications
You must be signed in to change notification settings - Fork 28
2.x Package Documentation Support #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mbabker
wants to merge
77
commits into
master
Choose a base branch
from
package-documentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+5,623
−12,620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s don't exist for a branch on the redirect controller
I've pushed the latest changes from master into this branch to bring it up to date. @nibra @HLeithner maybe you want to have a look at this and if we want to adopt this finally? |
nibra
reviewed
Aug 23, 2022
nibra
reviewed
Aug 23, 2022
nibra
reviewed
Aug 23, 2022
…package-documentation # Conflicts: # composer.lock # www/media/css/template.css # www/media/css/template.css.map # www/media/js/template.js # www/media/js/template.js.map # www/media/mix-manifest.json # www/media/sri-manifest.json
The question is: Who is going to finish this PR and who is going to write all that documentation? |
9912ebf
to
d418ff4
Compare
…package-documentation # Conflicts: # composer.json # composer.lock # package-lock.json # src/Model/PackageModel.php # src/Service/ApplicationProvider.php # www/index.php # www/media/css/template.css # www/media/css/template.css.map # www/media/mix-manifest.json # www/media/sri-manifest.json
…package-documentation # Conflicts: # composer.json # composer.lock # package-lock.json # src/Model/PackageModel.php # src/Service/ApplicationProvider.php # www/index.php # www/media/css/template.css # www/media/css/template.css.map # www/media/mix-manifest.json # www/media/sri-manifest.json
# Conflicts: # composer.json # composer.lock # etc/migrations/20230203231400_add_v3_info.php # package-lock.json # packages.yml # src/Command/Package/SyncCommand.php # src/Helper.php # src/Model/PackageModel.php # src/Model/ReleaseModel.php # templates/status.twig # www/media/css/template.css # www/media/css/template.css.map # www/media/js/template.js # www/media/js/template.js.map # www/media/mix-manifest.json # www/media/sri-manifest.json
# Conflicts: # composer.json # composer.lock # src/DebugWebApplication.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infrastructure and UI changes needed for supporting rendering package docs on this website.
symfony/cache
package to cache rendered markupjoomla/github
to render markup via GitHub API in appropriate context/docs/:version/:package/:filename
is the general pattern, where::version
is either a major version branch (1.x or 2.x) or the shortcut "latest" (which will redirect to 2.x for now):package
is the package name:filename
is the path to the file within a repo's docs directory (when omitted it redirects to the overview page)