-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] [RFC] CMSPlugin: Subscriber Registration Checker Interface #43657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fedik
wants to merge
8
commits into
joomla:6.0-dev
Choose a base branch
from
Fedik:plg-registerlistener-checker
base: 6.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
This pull request has been automatically rebased to 5.3-dev. |
Conflicts: plugins/system/guidedtours/src/Extension/GuidedTours.php
This was referenced Mar 2, 2025
This pull request has been automatically rebased to 6.0-dev. |
4 tasks
Conflicts: libraries/src/Plugin/PluginHelper.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adding Subscriber Registration Checker. Interface that allows Plugins to be checked before listener registration.
This allows the plugin to be registered only wheen special conditions are met, eg: only for specific application.
Testing Instructions
Code review by maintainers.
Edit
joomla-cms/plugins/system/guidedtours/src/Extension/GuidedTours.php
Lines 124 to 126 in 98f3ecd
And add
dd('Works');
at top of this method.Then open Administrator page: you should get message "works"
And then open Site page: the page should be opened as usual
Link to documentations
Please select: