-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Removing Adapter and AdapterInstance classes #43794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can they be moved to the compat plugin instead and then remove in 7? |
These classes have been broken sind Joomla 1.5 and have been deprecated since Joomla 4.3. It is impossible to use them without mostly re-implementing them entirely in your own class. There is NO code out there, which can use these classes. There is no gain whatsoever in keeping them. |
I have tested this item ✅ successfully on 933e78d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43794. |
I have tested this item ✅ successfully on 933e78d
|
Summary of Changes
This PR removes the deprecated classes Adapter and AdapterInstance. It depends on #43792 and #43793. Those PRs remove the dependency on these classes. Thus this PR can only be merged when those 2 have been merged.
Testing Instructions
Codereview.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: CMS Adapter removed Manual#301
No documentation changes for manual.joomla.org needed