Skip to content

[6.0] Added typehints for new functions from #40613 #44740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 22, 2025
Merged

[6.0] Added typehints for new functions from #40613 #44740

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
659973c
Added typehints for new functions from #40613
Bodge-IT Jan 17, 2025
4399bc1
Update libraries/src/Helper/TagsHelper.php
Bodge-IT Jan 19, 2025
478e07d
Update TagsHelper.php
Bodge-IT Jan 19, 2025
8c7df79
Merge branch '6.0-dev' into Add_typehints_to_new_functions_from_40613
softforge Jan 22, 2025
514b645
Merge branch '6.0-dev' into Add_typehints_to_new_functions_from_40613
Bodge-IT Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions libraries/src/Helper/TagsHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,9 +825,11 @@ public static function getTypes($arrayType = 'objectList', $selectTypes = null,
*
* @deprecated 5.3 will be removed in 7.0
*/
public function postStoreProcess(TableInterface $table, $newTags = [], $replace = true)
public function postStoreProcess(TableInterface $table, $newTags = [], $replace = true): void
{
$this->postStore($table, $newTags, $replace);
@trigger_error('7.0 Method postStoreProcess() is deprecated, use postStore() instead.', \E_USER_DEPRECATED);

$this->postStore($table, (array) $newTags, (bool) $replace);
}

/**
Expand All @@ -843,7 +845,7 @@ public function postStoreProcess(TableInterface $table, $newTags = [], $replace
*
* @since __DEPLOY_VERSION__
*/
public function postStore(TableInterface $table, $newTags = [], $replace = true, $remove = false)
public function postStore(TableInterface $table, array $newTags = [], bool $replace = true, bool $remove = false): bool
{
if (!empty($table->newTags) && empty($newTags)) {
$newTags = $table->newTags;
Expand Down