Skip to content

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented May 5, 2025

Summary of Changes

Removes fetchExtensionCompatibility in UpdateController class as it is not used since

Testing Instructions

Install test sample data and browse around the front end and back end.

Actual result BEFORE applying this Pull Request

All is working.

Expected result AFTER applying this Pull Request

All is working.

Link to documentations

Please select:

@laoneo laoneo added the b/c break This item changes the behavior in an incompatible why. HEADS UP label May 5, 2025
@HLeithner
Copy link
Member

can we please fix the camelCase for the batch function... it's not a b/c break and makes it constant to our code base and would be a good point in time before documentation

https://3v4l.org/bQHFu

@laoneo
Copy link
Member Author

laoneo commented May 5, 2025

I'm not sure if it is like that because of the task parameter in the url? Did you test it with the camelCase name?

@Bodge-IT
Copy link
Contributor

@laoneo How would someone test this?

@laoneo
Copy link
Member Author

laoneo commented May 19, 2025

As this function is not used in core at all, there is nothing to test.

@laoneo
Copy link
Member Author

laoneo commented May 19, 2025

The closest you can do is to case insensitive search for the function name.

@laoneo laoneo closed this May 26, 2025
@laoneo laoneo deleted the remove/fetchext branch May 26, 2025 07:25
@rdeutz rdeutz restored the remove/fetchext branch May 28, 2025 16:16
@rdeutz rdeutz reopened this May 28, 2025
@ceford
Copy link
Contributor

ceford commented May 30, 2025

I have tested this item ✅ successfully on 2e596a8

Searched code for removed function and poked around in front end and back end. No problems.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436.

@muhme
Copy link
Contributor

muhme commented May 30, 2025

I have tested this item ✅ successfully on 2e596a8

Verified that the method is not used:

git clone https://github.com/joomla/joomla-cms -b 6.0-dev 60
# test before the PR
find 60 -name \*.php | xargs grep -i fetchExtensionCompatibility                                                  
60/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php:    public function fetchExtensionCompatibility()
60/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php:     * Called by controller's fetchExtensionCompatibility, which is called via AJAX.
# Apply the PR
gh pr checkout 45436
# Retest
find 60 -name \*.php | xargs grep -i fetchExtensionCompatibility
# nothing found :)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 2, 2025
@Bodge-IT Bodge-IT merged commit e93c78c into joomla:6.0-dev Jun 12, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 12, 2025
@Bodge-IT
Copy link
Contributor

Thanks for the work @laoneo and thanks to @muhme & @ceford for time to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants