-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Removes fetchExtensionCompatibility in UpdateController class #45436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
can we please fix the camelCase for the batch function... it's not a b/c break and makes it constant to our code base and would be a good point in time before documentation |
I'm not sure if it is like that because of the task parameter in the url? Did you test it with the camelCase name? |
@laoneo How would someone test this? |
As this function is not used in core at all, there is nothing to test. |
The closest you can do is to case insensitive search for the function name. |
I have tested this item ✅ successfully on 2e596a8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436. |
I have tested this item ✅ successfully on 2e596a8 git clone https://github.com/joomla/joomla-cms -b 6.0-dev 60
# test before the PR
find 60 -name \*.php | xargs grep -i fetchExtensionCompatibility
60/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php: public function fetchExtensionCompatibility()
60/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php: * Called by controller's fetchExtensionCompatibility, which is called via AJAX.
# Apply the PR
gh pr checkout 45436
# Retest
find 60 -name \*.php | xargs grep -i fetchExtensionCompatibility
# nothing found :) This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436. |
Summary of Changes
Removes
fetchExtensionCompatibility
inUpdateController
class as it is not used sinceTesting Instructions
Install test sample data and browse around the front end and back end.
Actual result BEFORE applying this Pull Request
All is working.
Expected result AFTER applying this Pull Request
All is working.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Removes fetchExtensionCompatibility in UpdateController class Manual#460
No documentation changes for manual.joomla.org needed