Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Jul 18, 2025

Summary of Changes

The Joomla CMS contains a http package which is almost an identical copy of the Joomla framework http package. This PR deprecates the CMS package and converts all CMS code to use the framework package with the PSR-7 interface.

Please note that there are small differences between the CMS and framework package, which I couldn't resolve directly. These would have to be reviewed and probably adapted for the framework package before 6.0 release:

  • HTTPFactory::getHttp() sets userAgent to Joomla <version>
  • Joomla\Http\Transport\Stream::getResponse() is not identical
  • Joomla\Http\Transport\Socket::getResponse() is not identical
  • Joomla\Http\Transport\Curl::getResponse() and redirectsAllowed() are not identical

The differences between the packages have adressed here: joomla-framework/http#67

Testing Instructions

Codereview

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: Deprecate Joomla\CMS\Http package Manual#498

  • No documentation changes for manual.joomla.org needed

@Hackwar
Copy link
Member Author

Hackwar commented Aug 3, 2025

Large parts of this PR should be unnecessary when #45825 is merged.

@Bodge-IT
Copy link
Contributor

Hi @Hackwar , got our eye this one Hannes. #45825 is merged, can we we close the loop on this one?

@Hackwar Hackwar marked this pull request as ready for review August 15, 2025 14:12
@richard67
Copy link
Member

I have tested this item ✅ successfully on 0642199

Code review: All classes and methods have been deprecated (if they were not before), and the deprecation comments are correct.

The usage of the deprecated code has already been removed in the CMS (6-0-dev) with PR #45825 .


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45751.

@brianteeman
Copy link
Contributor

How do you test the magic getter?

The rest is ok but as I can't test that part (yet) I can't give it a successful test

@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on 0642199

Code Review - LGTM


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45751.

@softforge softforge added this to the Joomla! 6.0.0 milestone Aug 15, 2025
@softforge softforge merged commit a99398f into joomla:6.0-dev Aug 15, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Deprecations cleanup Aug 15, 2025
@softforge
Copy link
Contributor

Thank you for your speedy fix and the testers for their amazing help

@richard67
Copy link
Member

How do you test the magic getter?

The rest is ok but as I can't test that part (yet) I can't give it a successful test

@brianteeman The getter is the same as in v3 of the framework package: https://github.com/joomla-framework/http/blob/3.x-dev/src/Response.php#L35-L61

@richard67
Copy link
Member

... except of the $stream->rewind();, which is new here, but that is necessary and just was missing the framework.

@brianteeman
Copy link
Contributor

Thanks @richard67

I wonder how anyone was able to test it

@Hackwar Hackwar deleted the 6.0-http branch August 15, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants