[6.1] Allow ordering of subform if saved as json and allow postprocessing of subform child fields #46024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you create an subform for multiple rows and allow to order and save this subform as json, it is not possible to reorder entries.
There might be an alternative to fix this issue in the javascript. But that would not fix the postprocessing issue of subform child fields.
Summary of Changes
This PR changes the associative array result to an indexed array by walking recursive thru all subforms.
This behavior can be activated by adding the
indexed="true"?
attribute to the subform xml definition.We use an extra attribute to b/c reasons, but would also expect that there should no problems changing this behavior for all subforms without a switch.
We can think about deprecating the old behavior.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed