-
Notifications
You must be signed in to change notification settings - Fork 11
Lesson 1 - constructors, prototypes and inheritance #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oddswop
wants to merge
1
commit into
joshdmiller:master
Choose a base branch
from
oddswop:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import test from 'tape'; | ||
| import { double, doubleXTimes, doubleEach } from './index'; | ||
| import { double, doubleXTimes, doubleEach, tripleEach, Animal, Reptile, Primate, Human } from './index'; | ||
|
|
||
| test( 'double fn', function ( test ) { | ||
| const actual = double( 5 ); | ||
|
|
@@ -28,3 +28,83 @@ test( 'doubleEach', function ( test ) { | |
| test.end(); | ||
| }); | ||
|
|
||
| // just checking if I can 'copy paste'! | ||
| // | ||
| //test ( 'tripleEach', function ( test ) { | ||
| // const actual = tripleEach([1, 3 ,6]); | ||
| // const expected = [3, 9, 18]; | ||
| // | ||
| // test.deepEqual( actual, expected, 'should triple each in the array'); | ||
| // | ||
| // test.end(); | ||
| //}); | ||
|
|
||
| // lesson 1 activity - try and make test pass. | ||
|
|
||
| test ( 'Animal', function ( test ) { | ||
| const animal = new Animal (); // constructor | ||
|
|
||
| test.ok( animal instanceof Animal, 'should create an instance of Animal'); | ||
|
|
||
| // console.log(animal); | ||
|
|
||
| test.end(); | ||
| }); | ||
|
|
||
| test ('Animal', function (test) { | ||
| const animal = new Animal (); | ||
| const expected = 'generic sound'; | ||
| const actual = animal.speak(); | ||
|
|
||
| test.equal( actual, expected, 'should make a generic sound when it speaks'); | ||
|
|
||
| test.end(); | ||
| }); | ||
|
|
||
|
|
||
|
|
||
| // inheritance | ||
| // | ||
| // | ||
|
|
||
| test ('Inheritance', function (test) { | ||
| let actual, expected; | ||
|
|
||
|
|
||
| const reptile = new Reptile(); | ||
|
|
||
| test.ok( reptile instanceof Reptile, 'should be an instance of Reptile' ); | ||
| test.ok( reptile instanceof Animal, 'should be an instance of Animal' ); | ||
|
|
||
| expected = Reptile.SOUND; | ||
| actual = reptile.speak(); | ||
| test.equal( actual, expected, 'should make a reptile sound when it speaks' ); | ||
|
|
||
| const primate = new Primate(); | ||
|
|
||
| test.ok( primate instanceof Primate, 'should be an instance of Primate' ); | ||
| test.ok( primate instanceof Animal, 'should be an instance of Animal' ); | ||
|
|
||
| expected = Primate.SOUND; | ||
| actual = primate.speak(); | ||
| test.equal( actual, expected, 'should make a primate sound when it speaks' ); | ||
| test.end(); | ||
| }); | ||
|
|
||
| test ('Inheritance Human', function (test){ | ||
|
|
||
| let actual, expected; | ||
|
|
||
| const human = new Human(); | ||
|
|
||
| test.ok( human instanceof Human, 'should be an instance of Human' ); | ||
| test.ok( human instanceof Primate, 'should be an instance of Primate' ); | ||
| test.ok( human instanceof Animal, 'should be an instance of Animal' ); | ||
|
|
||
| const message = 'hello'; | ||
| expected = message; | ||
| actual = human.speak( message ); | ||
| test.equal( actual, expected, 'should speak what it is asked to speak' ); | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't seem quite right. Why are you passing in the message as an argument, but not using it in your function? |
||
|
|
||
| test.end() | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I couldn't think of a good reptile sound.