perf: make anyForSubtypeOf cacheable #634
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a prototype that might resolve #624
Details
It turns out kotlinc inserts "sam wrappers" when converting Kotlin lambdas into Java functional interfaces. The sam wrappers do not have equals/hashCode, so it defeats jqwik's caching.
The fix is to move out
.flatMap { ... }out ofinlinefunction, so kotlinc no longer addssam wrappers.TODO:
DefaultTypeArbitrary.equalsshould account fortraverseArbitrary.enableRecursionsomehownet.jqwik.kotlin.api.SubtypeScope#hashCodedoes not seem to trigger when executingAnyForSubtypeOfTests. I guess it should somehowanyForSubtypeOfI hereby agree to the terms of the jqwik Contributor Agreement.