[feat] make logger in Rails include AS::LoggerSilence #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I have the Rails logging expertise to seriously evaluate this but I'll have a go! |
|
apologies, was testing out a (AI) work-flow locally and ended up with a premature merge... 🍼 |
|
giving up on co-pilot here, asked it for a revert and re-open a got me with: #307 😒 |
kares
commented
Aug 1, 2025
| ActiveSupport::TaggedLogging.new(logger) # returns a logger.clone | ||
| logger = ActiveSupport::TaggedLogging.new(logger) # returns a logger.clone | ||
| logger.singleton_class.instance_eval do | ||
| include ActiveSupport::LoggerSilence if defined?(ActiveSupport::LoggerSilence) |
There was a problem hiding this comment.
should have just send(:include) here instead of eval-ing...
| end | ||
|
|
||
| # Silences the logger for the duration of the block. | ||
| def silence(severity = Logger::ERROR) |
There was a problem hiding this comment.
maybe we should remove logger.silence from JRuby::Rack::Logger impl, which includes a dummy silence(level) { ... } implementation that does nothing (simply yields).
This was referenced Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relevant changes in src/main/ruby/jruby/rack/rails/railtie.rb
the rest is getting stubs from Rails to be able to test this wout actual Rails
an alternative proposal to: #270